From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbdLGVPp (ORCPT ); Thu, 7 Dec 2017 16:15:45 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48253 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750996AbdLGVPn (ORCPT ); Thu, 7 Dec 2017 16:15:43 -0500 X-ME-Sender: Date: Fri, 8 Dec 2017 08:15:39 +1100 From: "Tobin C. Harding" To: Joe Perches Cc: Andy Whitcroft , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] checkpatch: warn for use of %px Message-ID: <20171207211539.GL2191@eros> References: <1512531428-3592-1-git-send-email-me@tobin.cc> <1512531428-3592-4-git-send-email-me@tobin.cc> <20171207210653.GK2191@eros> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207210653.GK2191@eros> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 08:06:53AM +1100, Tobin C. Harding wrote: > On Wed, Dec 06, 2017 at 02:37:08PM +1100, Tobin C. Harding wrote: > > Usage of the new %px specifier potentially leaks sensitive > > inforamtion. Printing kernel addresses exposes the kernel layout in > > memory, this is potentially exploitable. We have tools in the kernel to > > help us do the right thing. We can have checkpatch warn developers of > > potential dangers of using %px. > > > > Have checkpatch emit a warning for usage of specifier %px. > > > > Signed-off-by: Tobin C. Harding > > Co-developed-by: Joe Perches > > Co-Developed-by: > > Woops. > > Joe I didn't quite understand what you meant when you said that this > could go in via any tree. I'm still learning the whole kernel tree > management thing. Don't checkpatch patches go in via Andy's tree? > > https://git.kernel.org/pub/scm/linux/kernel/git/apw/checkpatch.git/ Oh, I see that tree is not super active. If there are no NACK's do you want me to put this through my tree? Perhaps once the Co-Developed-by stuff is in an acceptable form we could put them all together? Please do say if I'm going about things wrong, here to learn. thanks, Tobin.