From: Ingo Molnar <mingo@kernel.org>
To: alexander.levin@verizon.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 2/2] tools/lib/lockdep: add empty declaration for early_param
Date: Fri, 8 Dec 2017 07:20:10 +0100 [thread overview]
Message-ID: <20171208062010.yrcbazicfut7pmk2@gmail.com> (raw)
In-Reply-To: <20171208060920.u56ee3kkyyqdmjol@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
>
> * alexander.levin@verizon.com <alexander.levin@verizon.com> wrote:
>
> > Fixes a compilation error:
> >
> > CC lockdep.o
> > In file included from lockdep.c:28:0:
> > ../../../kernel/locking/lockdep.c:89:13: error: expected declaration specifiers or ‘...’ before string constant
> > early_param("crossrelease_fullstack", allow_crossrelease_fullstack);
> > ^~~~~~~~~~~~~~~~~~~~~~~~
> > ../../../kernel/locking/lockdep.c:89:39: error: expected declaration specifiers or ‘...’ before ‘allow_crossrelease_fullstack’
> > early_param("crossrelease_fullstack", allow_crossrelease_fullstack);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Ugh, this changelog was in DOS format (had extra \r's) - how did that happen?
Hm, so it's because the second patch email was sent as as a base64 encoded email:
Content-Transfer-Encoding: base64
totally not recommended and git-send-email will not do that - what happened?
>
> Fixed it up.
Actually, could you please resend the whole series, with a fix for the other
warning I reported added, with the changelogs fixed, and not MIME encoded?
Thanks,
Ingo
next prev parent reply other threads:[~2017-12-08 6:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 16:11 [PATCH 0/2] tools/lib/lockdep: fixes for v4.15 alexander.levin
2017-12-07 16:11 ` [PATCH 1/2] tools/lib/lockdep: Add missing declaration of 'pr_cont()' alexander.levin
2017-12-08 6:19 ` Ingo Molnar
2017-12-07 16:11 ` [PATCH 2/2] tools/lib/lockdep: add empty declaration for early_param alexander.levin
2017-12-08 6:09 ` Ingo Molnar
2017-12-08 6:20 ` Ingo Molnar [this message]
2017-12-08 14:03 ` alexander.levin
2017-12-11 14:45 ` Ingo Molnar
2017-12-08 6:07 ` [PATCH 0/2] tools/lib/lockdep: fixes for v4.15 Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2017-12-12 18:16 [GIT PULL " alexander.levin
2017-12-12 18:16 ` [PATCH 2/2] tools/lib/lockdep: add empty declaration for early_param alexander.levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208062010.yrcbazicfut7pmk2@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.levin@verizon.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox