From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbdLHGUO (ORCPT ); Fri, 8 Dec 2017 01:20:14 -0500 Received: from mail-wr0-f172.google.com ([209.85.128.172]:37902 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdLHGUN (ORCPT ); Fri, 8 Dec 2017 01:20:13 -0500 X-Google-Smtp-Source: AGs4zMZAlJLgi4L2NiJjxhwkXzpr0UJ7H2KvoQIm61BLEMll6Wu+ugKLWEEaU890vM7PJ/h3vh//VA== Date: Fri, 8 Dec 2017 07:20:10 +0100 From: Ingo Molnar To: alexander.levin@verizon.com Cc: "linux-kernel@vger.kernel.org" , Peter Zijlstra Subject: Re: [PATCH 2/2] tools/lib/lockdep: add empty declaration for early_param Message-ID: <20171208062010.yrcbazicfut7pmk2@gmail.com> References: <20171207161057.7406-1-alexander.levin@verizon.com> <20171207161057.7406-3-alexander.levin@verizon.com> <20171208060920.u56ee3kkyyqdmjol@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171208060920.u56ee3kkyyqdmjol@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > > * alexander.levin@verizon.com wrote: > > > Fixes a compilation error: > > > > CC lockdep.o > > In file included from lockdep.c:28:0: > > ../../../kernel/locking/lockdep.c:89:13: error: expected declaration specifiers or ‘...’ before string constant > > early_param("crossrelease_fullstack", allow_crossrelease_fullstack); > > ^~~~~~~~~~~~~~~~~~~~~~~~ > > ../../../kernel/locking/lockdep.c:89:39: error: expected declaration specifiers or ‘...’ before ‘allow_crossrelease_fullstack’ > > early_param("crossrelease_fullstack", allow_crossrelease_fullstack); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Ugh, this changelog was in DOS format (had extra \r's) - how did that happen? Hm, so it's because the second patch email was sent as as a base64 encoded email: Content-Transfer-Encoding: base64 totally not recommended and git-send-email will not do that - what happened? > > Fixed it up. Actually, could you please resend the whole series, with a fix for the other warning I reported added, with the changelogs fixed, and not MIME encoded? Thanks, Ingo