From: Andrea Parri <parri.andrea@gmail.com>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, patches@groups.riscv.org,
stern@rowland.harvard.edu, paulmck@linux.vnet.ibm.com
Subject: Re: [patches] Re: [GIT PULL] RISC-V Cleanups and ABI Fixes for 4.15-rc2
Date: Fri, 8 Dec 2017 11:03:45 +0100 [thread overview]
Message-ID: <20171208100345.GA4209@andrea> (raw)
In-Reply-To: <mhng-e4f55571-c4df-465d-b296-e9f3554a6292@palmer-si-x1c4>
On Thu, Dec 07, 2017 at 12:59:35PM -0800, Palmer Dabbelt wrote:
> On Sat, 02 Dec 2017 19:20:02 PST (-0800), parri.andrea@gmail.com wrote:
> >On Fri, Dec 01, 2017 at 01:39:12PM -0800, Palmer Dabbelt wrote:
> >> RISC-V: Remove smb_mb__{before,after}_spinlock()
> >
> >I wonder whether you really meant to remove smp_mb__after_spinlock():
> >on the one hand, this primitive doesn't seem "obsolete" (as suggested
> >by the commit message); on the other hand, the Draft Specification at
> >
> > https://marc.info/?l=linux-kernel&m=151218405830993&w=2
> >
> >suggests that you need "to strengthen" the generic implementation for
> >this primitive (considered the current spinlock.h in riscv). What am
> >I missing?
>
> The comment was incorrect, which caused me to incorrectly remove the fence
> from our port. I just sent out a patch (well, actually, I did last night --
> I just found this email sitting in a buffer...).
>
> https://lkml.org/lkml/2017/12/6/1136
Thank you for the clarification (and for the patch),
Andrea
>
> Thanks for catching this!
prev parent reply other threads:[~2017-12-08 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 21:39 [GIT PULL] RISC-V Cleanups and ABI Fixes for 4.15-rc2 Palmer Dabbelt
2017-12-02 0:47 ` Linus Torvalds
2017-12-02 1:47 ` Palmer Dabbelt
2017-12-03 3:20 ` Andrea Parri
2017-12-07 20:59 ` [patches] " Palmer Dabbelt
2017-12-08 10:03 ` Andrea Parri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208100345.GA4209@andrea \
--to=parri.andrea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=palmer@sifive.com \
--cc=patches@groups.riscv.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox