From: Olaf Hering <olaf@aepfle.de>
To: Eduardo Otubo <otubo@redhat.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
sthemmin@microsoft.com, haiyangz@microsoft.com,
kys@microsoft.com, vkuznets@redhat.com, mgamal@redhat.com,
cavery@redhat.com
Subject: Re: [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip
Date: Fri, 8 Dec 2017 12:33:38 +0100 [thread overview]
Message-ID: <20171208113338.GA3134@aepfle.de> (raw)
In-Reply-To: <20171208102056.4725-1-otubo@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On Fri, Dec 08, Eduardo Otubo wrote:
> tools/hv/hv_set_ifconfig.sh | 45 +++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 43 insertions(+), 2 deletions(-)
> + # let's wait for 3 minutes
Was this codepath runtime tested?
Last time this came up, the conclusion was that Windows terminates the
"KVP connection" after 60 seconds. After that, the VM must be rebooted
because the kernel does not deal with the long-running script. It is
also not clear what the kernel is supposed to do: either silently report
success and hope the scripts reports success one day, or report error
independent from what the script actually returns. New KVP requests
would need to be queued either way.
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-12-08 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 10:20 [PATCHv2] tools: hv: hv_set_ifconfig.sh double check before setting ip Eduardo Otubo
2017-12-08 11:33 ` Olaf Hering [this message]
2017-12-08 13:43 ` Eduardo Otubo
2017-12-08 19:04 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208113338.GA3134@aepfle.de \
--to=olaf@aepfle.de \
--cc=cavery@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgamal@redhat.com \
--cc=otubo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox