From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbdLHLoM (ORCPT ); Fri, 8 Dec 2017 06:44:12 -0500 Received: from mga03.intel.com ([134.134.136.65]:52978 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbdLHLoK (ORCPT ); Fri, 8 Dec 2017 06:44:10 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,377,1508828400"; d="scan'208";a="11674294" Date: Fri, 8 Dec 2017 13:44:04 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Augustine.Chen" Cc: intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org, jerome.anand@intel.com, pierre-louis.bossart@intel.com, tiwai@suse.de, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jiang Liu , Juergen Gross , Dou Liyang , linux-kernel@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Message-ID: <20171208114404.GN10981@intel.com> References: <20171208093323.2212-1-augustine.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171208093323.2212-1-augustine.chen@intel.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 05:33:23PM +0800, Augustine.Chen wrote: > The chip data of HDMI LPE audio is set to drm_i915_private which is not > consistent with the expectation by x86 APIC driver. Hmm. Why is the apic code looking at data for an irq chip it hasn't created? Do we need something like - dev_priv->lpe_audio.irq = irq_alloc_desc(0); + dev_priv->lpe_audio.irq = irq_alloc_desc(-1); ? That *looks* more correct to me based on a cursory glance at the x86 code, but I didn't trawl very deeply. > In the case of not > enabling CONFIG_CPUMASK_OFFSTACK, this would cause kernel panic while doing > CPU hotplug. Since the dependency of IRQ chip data was removed from HDMI > LPE audio by Commit 9bd9590997b92fbd79fd028f704f6c584b4439d7 ("drm/i915: > Stop pretending to mask/unmask LPE audio interrupts"), remove the > code of setting IRQ chip data to resolve this issue. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103731 > Cc: Pierre-Louis Bossart > Cc: Jerome Anand > Cc: Takashi Iwai > Signed-off-by: Augustine.Chen > --- > drivers/gpu/drm/i915/intel_lpe_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c > index 3bf6528..56176f9 100644 > --- a/drivers/gpu/drm/i915/intel_lpe_audio.c > +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c > @@ -176,7 +176,7 @@ static int lpe_audio_irq_init(struct drm_i915_private *dev_priv) > handle_simple_irq, > "hdmi_lpe_audio_irq_handler"); > > - return irq_set_chip_data(irq, dev_priv); > + return 0; > } > > static bool lpe_audio_detect(struct drm_i915_private *dev_priv) > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC