From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbdLHLz0 (ORCPT ); Fri, 8 Dec 2017 06:55:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48856 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753105AbdLHLzS (ORCPT ); Fri, 8 Dec 2017 06:55:18 -0500 Date: Fri, 8 Dec 2017 12:55:15 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra , Michael Petlan Subject: Re: [PATCH] perf tests: Handle properly readdir DT_UNKNOWN Message-ID: <20171208115515.GD2799@krava> References: <20171206174535.25380-1-jolsa@kernel.org> <20171207151905.GC6458@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171207151905.GC6458@kernel.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 08 Dec 2017 11:55:18 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 07, 2017 at 12:19:05PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 06, 2017 at 06:45:35PM +0100, Jiri Olsa escreveu: > > Some system can return DT_UNKNOWN in readdir's struct dirent::d_type > > and we must handle it properly. In this case we can directly check > > if the entity we found is directory and skip it. > > > Making is_directory function global. > > Split this part into a prep patch and left with the previous paragraph > the 'perf test' bits. > > [acme@jouet perf]$ git log --oneline -2 > de7cee586145 (HEAD -> perf/core, acme.korg/perf/core) perf test: Handle properly readdir DT_UNKNOWN > ef87e1133606 perf utils: Move is_directory() to path.h > [acme@jouet perf]$ thanks, jirka