From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753827AbdLIBSx (ORCPT ); Fri, 8 Dec 2017 20:18:53 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52369 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753767AbdLIBSw (ORCPT ); Fri, 8 Dec 2017 20:18:52 -0500 X-ME-Sender: Date: Sat, 9 Dec 2017 12:18:45 +1100 From: "Tobin C. Harding" To: Greg Kroah-Hartman Cc: Joe Perches , linux-kernel@vger.kernel.org, Andy Whitcroft Subject: Re: [PATCH 4/4] checkpatch: add check for tag Co-Developed-by Message-ID: <20171209011845.GA2191@eros> References: <1512689271-28051-1-git-send-email-me@tobin.cc> <1512689271-28051-5-git-send-email-me@tobin.cc> <20171208074252.GA16137@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208074252.GA16137@kroah.com> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 08:42:52AM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 08, 2017 at 10:27:51AM +1100, Tobin C. Harding wrote: > > From: Joe Perches > > > > Recently signature tag Co-Developed-by was added to the > > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know > > about it yet. All prior tags used all lowercase characters except for first > > character. Checks for this format had to be re-worked to allow for the > > new tag. > > > > Cc: Greg Kroah-Hartman > > > > Reviewed-by: Greg Kroah-Hartman > > Signed-off-by: Tobin C. Harding > > --- > > > > Greg, > > > > This patch has the same brief commit and achieves the same aim as the > > code you reviewed. I'm adding your tag here even though the code is > > totally different. I believe you were reviewing the behaviour of the > > code not the actual logic. > > Well, I did read the actual logic, I do know perl :) No offense meant, just trying to make your day easier. > Anyway, my reviewed-by still stands here, thanks. thanks, Tobin.