From: Jonathan Cameron <jic23@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] iio: light: make a couple of config structures static
Date: Sun, 10 Dec 2017 16:23:02 +0000 [thread overview]
Message-ID: <20171210162302.13236b42@archlinux> (raw)
In-Reply-To: <20171204120406.4364-1-colin.king@canonical.com>
On Mon, 4 Dec 2017 12:04:06 +0000
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Structures st_uvis25_i2c_regmap_config and st_uvis25_spi_regmap_config are
> local to the source and do not need to be in global scope, so make them
> both static.
>
> Cleans up sparse warnings:
> warning: symbol 'st_uvis25_i2c_regmap_config' was not declared. Should
> it be static?
> warning: symbol 'st_uvis25_spi_regmap_config' was not declared. Should
> it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin,
Not sure why I missed these when running build tests and they got past
0-day. Ah well.. Applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to play with them.
Thanks,
Jonathan
> ---
> drivers/iio/light/st_uvis25_i2c.c | 2 +-
> drivers/iio/light/st_uvis25_spi.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/st_uvis25_i2c.c b/drivers/iio/light/st_uvis25_i2c.c
> index c939c0b0ff10..afd6eb01a202 100644
> --- a/drivers/iio/light/st_uvis25_i2c.c
> +++ b/drivers/iio/light/st_uvis25_i2c.c
> @@ -19,7 +19,7 @@
>
> #define UVIS25_I2C_AUTO_INCREMENT BIT(7)
>
> -const struct regmap_config st_uvis25_i2c_regmap_config = {
> +static const struct regmap_config st_uvis25_i2c_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> .write_flag_mask = UVIS25_I2C_AUTO_INCREMENT,
> diff --git a/drivers/iio/light/st_uvis25_spi.c b/drivers/iio/light/st_uvis25_spi.c
> index e697e14e7952..cdfee5e84d5e 100644
> --- a/drivers/iio/light/st_uvis25_spi.c
> +++ b/drivers/iio/light/st_uvis25_spi.c
> @@ -19,7 +19,7 @@
> #define UVIS25_SENSORS_SPI_READ BIT(7)
> #define UVIS25_SPI_AUTO_INCREMENT BIT(6)
>
> -const struct regmap_config st_uvis25_spi_regmap_config = {
> +static const struct regmap_config st_uvis25_spi_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
> .read_flag_mask = UVIS25_SENSORS_SPI_READ | UVIS25_SPI_AUTO_INCREMENT,
prev parent reply other threads:[~2017-12-10 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 12:04 [PATCH][next] iio: light: make a couple of config structures static Colin King
2017-12-10 16:23 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171210162302.13236b42@archlinux \
--to=jic23@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).