From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbdLKBza (ORCPT ); Sun, 10 Dec 2017 20:55:30 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:43661 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbdLKBz0 (ORCPT ); Sun, 10 Dec 2017 20:55:26 -0500 X-Google-Smtp-Source: AGs4zMZVzRnNBXTyfkkvpsknxcnd7j+aCboZWAQMy6/3ems5YSthUutFZOz/RVlbTP2rVxzC7eevyg== Date: Mon, 11 Dec 2017 10:55:20 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Gopi Sai Teja , ngupta@vflare.org, linux-kernel@vger.kernel.org, v.narang@samsung.com, pankaj.m@samsung.com, a.sahrawat@samsung.com, prakash.a@samsung.com, himanshu.sh@samsung.com Subject: Re: [PATCH 1/1] zram: better utilization of zram swap space Message-ID: <20171211015520.GA6479@jagdpanzerIV> References: <1512634963-1079-1-git-send-email-gopi.st@samsung.com> <20171207084510.GA10341@jagdpanzerIV> <20171211001635.GA18762@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171211001635.GA18762@bbox> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (12/11/17 09:16), Minchan Kim wrote: [..] > I agree. zram shouldn't be aware of allocator internal. > It would be better for zram to use *int zs_max_zpage_size(struct zs_pool *pool)* > to set up max_zpage_size. > Let's hide the allocator's detail to the exported function. Hi Minchan, cool :) I'll re-spin the patch [in a day or two]. and then *may be* we can return to the huge-class watermark proposition. may be there can be a knob or something of that kind. -ss