From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752355AbdLKJhv (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Dec 2017 04:37:51 -0500
Received: from mail-qt0-f196.google.com ([209.85.216.196]:34828 "EHLO
        mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751356AbdLKJhs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Dec 2017 04:37:48 -0500
X-Google-Smtp-Source: AGs4zMaIEpQvPSiW1ZArrDRBp52BKw9TMlynhyBhdY0vtcW8dCOqiV44A4u56T3iUXLZ8yQ8N00wzA==
Date: Mon, 11 Dec 2017 10:37:44 +0100
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Hunter <jonathanh@nvidia.com>, linux-usb@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] usb: phy: tegra: Cleanup error messages
Message-ID: <20171211093744.GB10671@ulmo>
References: <ddf583790b551999ef063107be12a2d85e7b6a86.1512946782.git.digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="0ntfKIWw70PvrIHh"
Content-Disposition: inline
In-Reply-To: <ddf583790b551999ef063107be12a2d85e7b6a86.1512946782.git.digetx@gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--0ntfKIWw70PvrIHh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote:
> Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to
> dev_err() and use common errors message formatting across the driver for
> consistency.
>=20
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/usb/phy/phy-tegra-usb.c | 72 +++++++++++++++++++++++++----------=
------
>  1 file changed, 44 insertions(+), 28 deletions(-)

Can we also get rid of all the function names in error messages? I see
that for some error messages you've removed them, but then for others
you added them, so you remove inconsistencies on one hand and add other
inconsistencies at the same time. =3D)

Other than that, I like this.

Thierry

--0ntfKIWw70PvrIHh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlouUeUACgkQ3SOs138+
s6GhUQ//XStPco0+7j9QNrv3r3O5C7PE4snO+i3NnG5jSEsItSmpzxSWV6A8jnsr
vPhLCGtjf0TAr2mEv/1fSNosJzN5cA4MZYgySQqLA9Iyeub9zTAk4eSWKgz8NVZj
VodUv1NqESR66u5qP22TMOOFRNmuRNGzjdGl6d9343UewpPoVOtevBocme4+zbo2
9cMHN1Js/jXm3hdLcBzGAvySz9mI2bp2a9IINiei0mMg78uzefOB16ybvwmP58T2
T9Pfem/zJEknt8yBjxFR9EgKMBy6tcwFsN61jpm5Gcaj+oq20omwQL2wuqYuCrfP
hRfrbdid4ZxO5wpiiM92nS1gYeKLwbopY0BtwF7bGbNGJpiaNiLiFeZ3yEaATeo/
6bynf6AC0kZ5J74ZXN49EF99ajODQs25vN8e7bp1k+L4i2S17Ln2drkrNj+WOQ2q
drsQiq0zzaiPIhzGAFvvOVreeIqubHSbC1KlkQ8nGcfgo++8gkBRAtcpFKXNFeeg
UOilC9L5eTWauFLisHjeJSWuQ4tA0+sCEzFqgziTFuI7wOpHq0WqovnS2+xmsFMY
u2mbPeB7xH0Gte9WhcYVHT4dkqUjs4d8EE0m3LTv1p1LFUokaYW77rpfG2q5J036
ROuvu95YcttBm8SqKjIEMj7I6Lv3pj0tEsNYrYqjl69REsKu8Qw=
=yQ0J
-----END PGP SIGNATURE-----

--0ntfKIWw70PvrIHh--