From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbdLKXUJ (ORCPT ); Mon, 11 Dec 2017 18:20:09 -0500 Received: from ms.lwn.net ([45.79.88.28]:56132 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdLKXUG (ORCPT ); Mon, 11 Dec 2017 18:20:06 -0500 Date: Mon, 11 Dec 2017 16:20:04 -0700 From: Jonathan Corbet To: Cengiz Can Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: update i2c-dev.h warning in documentation Message-ID: <20171211162004.2185a7ef@lwn.net> In-Reply-To: <20171209231058.270ce75c@nostromo> References: <20171209231058.270ce75c@nostromo> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 Dec 2017 23:10:58 +0300 Cengiz Can wrote: > `dev-interface` document gives examples for accessing i2c from > userspace. > > There's a note warning developers about the different `i2c-dev.h` header > files which were shipped with the kernel and i2c-tools separately. > > However, these commits in i2c-tools repository suggests that the header > files are now identical (in functionality) and `i2c_*` functions are now > defined in a separate header called `i2c/smbus.h`, which is distributed > with i2c-tools: > > commit 652619121974 ("Minimize differences with kernel flavor") > commit 93caf007f4cb ("Move SMBus helper functions to include/i2c/smbus.h") > > Thus, I've converted the warning paragraph into a historical note and > updated the suggested header files. > > Signed-off-by: Cengiz Can So this seems like a worthwhile change, but the patch contains a number of unrelated changes, mostly white-space stuff it seems. Can you clean that up and resend? Thanks, jon