From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbdLKXed (ORCPT ); Mon, 11 Dec 2017 18:34:33 -0500 Received: from ms.lwn.net ([45.79.88.28]:56192 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdLKXeb (ORCPT ); Mon, 11 Dec 2017 18:34:31 -0500 Date: Mon, 11 Dec 2017 16:34:29 -0700 From: Jonathan Corbet To: Srinivas Kandagatla Cc: Mark Brown , Greg Kroah-Hartman , alsa-devel@alsa-project.org, sdharia@codeaurora.org, Rob Herring , Mark Rutland , pombredanne@nexb.com, j.neuschaefer@gmx.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v9 01/13] Documentation: Add SLIMbus summary Message-ID: <20171211163429.67b4704f@lwn.net> In-Reply-To: <138216ca-4351-f895-fae2-0289cf2a3872@linaro.org> References: <20171207102720.21071-1-srinivas.kandagatla@linaro.org> <20171207102720.21071-2-srinivas.kandagatla@linaro.org> <20171207103253.25834a68@lwn.net> <138216ca-4351-f895-fae2-0289cf2a3872@linaro.org> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 Dec 2017 23:22:51 +0000 Srinivas Kandagatla wrote: > > It seems you have kerneldoc comments for your data structures and at least > > some of your exported symbols. If you really want to document this stuff > > well, I'd suggest finishing out those comments, then pulling them into the > > documentation in the appropriate places. > Am sure all the exported symbols have kernel doc, I will pull them into > relevant sub sections. > > Do you think something like this http://paste.ubuntu.com/26135862/ makes > sense? At a first glance it looks good to me. Thanks, jon