From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753050AbdLKQiC (ORCPT ); Mon, 11 Dec 2017 11:38:02 -0500 Received: from mga07.intel.com ([134.134.136.100]:45262 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012AbdLKQh5 (ORCPT ); Mon, 11 Dec 2017 11:37:57 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="12486297" Date: Mon, 11 Dec 2017 22:11:41 +0530 From: Vinod Koul To: venkat.prashanth2498@gmail.com Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] DMA:omap-dma: Fix kernel compilation error and checkpatch issues Message-ID: <20171211164141.GR18649@localhost> References: <1513000833-17514-1-git-send-email-venkat.prashanth2498@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1513000833-17514-1-git-send-email-venkat.prashanth2498@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 07:30:33PM +0530, venkat.prashanth2498@gmail.com wrote: > From: Venkat Prashanth B U > > This is the patch to the omap-dma.c file that fixes > the following issues: Thanks Venkat for the patch, but unforntunately it has some issues. First a patch should do only one thing, here it is attempting to do 3 things. I would urge you to read up on Documentation/process/* files. They should help and feel free to ask. Also title should document the patch, what it does and not fixes. > 1.redefinition of 'omap_dma_filter_fn' in the line 1273 > of drivers/dma/omap-dma.c This one actually sounds okay > 2.drivers/dma/omap-dma.c:341: ERROR: code indent should > use tabs where possible reported by ./checkpatch.pl > > 3.drivers/dma/omap-dma.c:749: WARNING: Missing a blank > line after declarations reported by ./checkpatch.pl I typically dont take ./checkpatch.pl fixes as this causes many issues like backporting on stable. So please drop these > > Signed-off-by: Venkat Prashanth B U > --- > drivers/dma/omap-dma.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c > index 1dfc71c..2a40485 100644 > --- a/drivers/dma/omap-dma.c > +++ b/drivers/dma/omap-dma.c > @@ -338,7 +338,7 @@ static void omap_dma_stop(struct omap_chan *c) > if (val & (CCR_RD_ACTIVE | CCR_WR_ACTIVE)) > dev_err(c->vc.chan.device->dev, > "DMA drain did not complete on lch %d\n", > - c->dma_ch); > + c->dma_ch); > > omap_dma_glbl_write(od, OCP_SYSCONFIG, sysconfig); > } else { > @@ -746,6 +746,7 @@ static void omap_dma_issue_pending(struct dma_chan *chan) > */ > if (!c->cyclic) { > struct omap_dmadev *d = to_omap_dma_dev(chan->device); > + > spin_lock(&d->lock); > if (list_empty(&c->node)) > list_add_tail(&c->node, &d->pending); > @@ -1269,7 +1270,7 @@ static struct platform_driver omap_dma_driver = { > }, > }; > > -bool omap_dma_filter_fn(struct dma_chan *chan, void *param) > +bool omap_dma_filter_func(struct dma_chan *chan, void *param) > { > if (chan->device->dev->driver == &omap_dma_driver.driver) { > struct omap_dmadev *od = to_omap_dma_dev(chan->device); > -- > 1.9.1 > -- ~Vinod