From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752255AbdLLHVo (ORCPT ); Tue, 12 Dec 2017 02:21:44 -0500 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:57451 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbdLLHVj (ORCPT ); Tue, 12 Dec 2017 02:21:39 -0500 X-RM-TRANSID: 2ee15a2f8380b7a-e7889 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee45a2f837f276-9cdee Date: Tue, 12 Dec 2017 02:21:30 -0500 From: Yaowei Bai To: David Rientjes Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] make some functions return bool Message-ID: <20171212072130.GA12496@byw> Reply-To: baiyaowei@cmss.chinamobile.com References: <1513047319-22302-1-git-send-email-baiyaowei@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: > On Mon, 11 Dec 2017, Yaowei Bai wrote: > > > This patchset makes some *_is_* like functions return bool because > > these functions only use true or false as their return values. > > > > No functional changes. > > > > I think the concern about this type of patchset in the past is that it is > unnecessary churn and makes it more time consuming to research git history > without any significant improvement. While, relative to a modern computer with superb computional power, i think the additional time to search git history is negligable and this type of patchset is also a good practice for the kernel beginner guys. :)