From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752273AbdLLKyM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 05:54:12 -0500
Received: from mail-wr0-f179.google.com ([209.85.128.179]:36067 "EHLO
        mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751281AbdLLKyK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 05:54:10 -0500
X-Google-Smtp-Source: ACJfBou4Q+huuyBC1ZZe+Rd1raa0Y9HZpUCHtW3Fga85+sUrCB+yrJNuDVGrl/hjh4PNy9nn8kPHQQ==
Date: Tue, 12 Dec 2017 11:54:07 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de,
        xen-devel <xen-devel@lists.xenproject.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org,
        hpa@zytor.com
Subject: Re: [PATCH 2/2] x86-64/Xen: eliminate W+X mappings
Message-ID: <20171212105407.6vavvj57i6z2pzxp@gmail.com>
References: <5A2FBC570200007800196B3E@prv-mh.provo.novell.com>
 <5A2FBE540200007800196B52@prv-mh.provo.novell.com>
 <20171212103819.an2xxafjv3cdkuy7@gmail.com>
 <5A2FC2280200007800196BB8@prv-mh.provo.novell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5A2FC2280200007800196BB8@prv-mh.provo.novell.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Jan Beulich <JBeulich@suse.com> wrote:

> >>> On 12.12.17 at 11:38, <mingo@kernel.org> wrote:
> > * Jan Beulich <JBeulich@suse.com> wrote:
> >> --- 4.15-rc3/arch/x86/xen/mmu_pv.c
> >> +++ 4.15-rc3-x86_64-Xen-avoid-W+X/arch/x86/xen/mmu_pv.c
> >> @@ -1902,6 +1902,16 @@ void __init xen_setup_kernel_pagetable(p
> >>  	/* Graft it onto L4[511][510] */
> >>  	copy_page(level2_kernel_pgt, l2);
> >>  
> >> +	/* Zap execute permission from the ident map. Due to the sharing of
> >> +	 * L1 entries we need to do this in the L2. */
> > 
> > please use the customary (multi-line) comment style:
> > 
> >   /*
> >    * Comment .....
> >    * ...... goes here.
> >    */
> > 
> > specified in Documentation/CodingStyle.
> 
> I would have but didn't because all other comments in this function
> use this (wrong) style. I've concluded that consistency is better
> here than matching the style doc. If the Xen maintainers tell me
> otherwise, I'll happily adjust the patch.

Then it should be cleaned up in a separate patch. The file is in arch/x86/ and 
both Documentation/CodingStyle and Linus's position is pretty unambiguous on this, 
there's no special exceptions for ugliness in arch/x86/ as far as I'm concerned.

Please guys fix this mess, NAK otherwise.

Thanks,

	Ingo