From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753917AbdLLNb6 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 08:31:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50686 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754561AbdLLNby (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 08:31:54 -0500
Date: Tue, 12 Dec 2017 14:31:48 +0100
From: Cornelia Huck <cohuck@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, "Michael S . Tsirkin" <mst@redhat.com>,
        weiping zhang <zhangweiping@didichuxing.com>,
        virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_mmio: fix devm cleanup
Message-ID: <20171212143148.4a022816.cohuck@redhat.com>
In-Reply-To: <20171212132902.t5vxs2yujsth2v2h@lakrids.cambridge.arm.com>
References: <20171212125302.6846-1-mark.rutland@arm.com>
        <20171212140952.64d7908a.cohuck@redhat.com>
        <20171212132902.t5vxs2yujsth2v2h@lakrids.cambridge.arm.com>
Organization: Red Hat GmbH
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 12 Dec 2017 13:31:54 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 12 Dec 2017 13:29:02 +0000
Mark Rutland <mark.rutland@arm.com> wrote:

> On Tue, Dec 12, 2017 at 02:09:52PM +0100, Cornelia Huck wrote:

> > Shouldn't the cleanup in _remove() then be removed as well?  
> 
> Ah, I'd missed that.
> 
> I believe that can be removed, yes.
> 
> Should I spin a v2 with that folded in?

I think it has the same devm_ioremap vs. iounmap discrepancy, so it
should probably be folded in.