From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: "Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
Ceph Development <ceph-devel@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/ceph: delete unused ceph_file_layout_is_valid function
Date: Tue, 12 Dec 2017 20:52:04 -0500 [thread overview]
Message-ID: <20171213015204.GA28668@byw> (raw)
In-Reply-To: <CAOi1vP8f3fvkWg4yiLOsnMX2nq9yHWGOPYqySiB3cFJfo55QqA@mail.gmail.com>
On Tue, Dec 12, 2017 at 11:15:05AM +0100, Ilya Dryomov wrote:
> On Tue, Dec 12, 2017 at 2:56 AM, Yaowei Bai
> <baiyaowei@cmss.chinamobile.com> wrote:
> > There's no users of ceph_file_layout_is_valid, remove it.
>
> It'll get a user in the next kernel release -- we'll remove ad-hoc
> checks from ceph_calc_file_object_mapping() which is executed on every
> mapping and call ceph_file_layout_is_valid() once per layout instead.
Maybe we can re-add it when it's used indeed.
>
> Thanks,
>
> Ilya
prev parent reply other threads:[~2017-12-13 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 1:56 [PATCH] fs/ceph: delete unused ceph_file_layout_is_valid function Yaowei Bai
2017-12-12 10:15 ` Ilya Dryomov
2017-12-13 1:52 ` Yaowei Bai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213015204.GA28668@byw \
--to=baiyaowei@cmss.chinamobile.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox