From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: David Rientjes <rientjes@google.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] make some functions return bool
Date: Tue, 12 Dec 2017 21:58:04 -0500 [thread overview]
Message-ID: <20171213025804.GA21743@byw> (raw)
In-Reply-To: <81cc7b9e-8d3d-d529-7459-1d8a1e3baa65@infradead.org>
On Tue, Dec 12, 2017 at 06:32:32PM -0800, Randy Dunlap wrote:
> On 12/12/2017 06:14 PM, Yaowei Bai wrote:
> > On Tue, Dec 12, 2017 at 09:20:56AM -0800, Randy Dunlap wrote:
> >> On 12/11/2017 11:21 PM, Yaowei Bai wrote:
> >>> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote:
> >>>> On Mon, 11 Dec 2017, Yaowei Bai wrote:
> >>>>
> >>>>> This patchset makes some *_is_* like functions return bool because
> >>>>> these functions only use true or false as their return values.
> >>>>>
> >>>>> No functional changes.
> >>
> >> I agree with the idea that predicate-like functions are boolean functions
> >> and should return bool.
> >
> > Then you can use Acked-by to support me. :)
>
> Sure, but I didn't keep the patch emails.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks a lot.
>
>
> >> Whether you can get someone to merge the patches is a different subject.
> >
> > The kernel development is not just developing hard codes. The talented
> > guys develop new features and bugfixes, while the other ones do cleanups
> > for them. These two parts of work are all welcome and should be
> > accepted by our community.
> >
> >>
> >>>> I think the concern about this type of patchset in the past is that it is
> >>>> unnecessary churn and makes it more time consuming to research git history
> >>>> without any significant improvement.
> >>>
> >>> While, relative to a modern computer with superb computional power, i
> >>> think the additional time to search git history is negligable and this
> >>> type of patchset is also a good practice for the kernel beginner guys.
> >>> :)
> >>
> >>
> >> --
> >> ~Randy
>
>
>
> --
> ~Randy
next prev parent reply other threads:[~2017-12-13 2:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 2:55 [PATCH 0/8] make some functions return bool Yaowei Bai
2017-12-12 2:55 ` [PATCH 1/8] mm/memblock: memblock_is_map/region_memory can be boolean Yaowei Bai
2017-12-12 16:03 ` Joe Perches
2017-12-13 2:32 ` Yaowei Bai
2017-12-12 2:55 ` [PATCH 2/8] mm/mmzone: mm/lru: is_file/active_lru " Yaowei Bai
2017-12-12 2:55 ` [PATCH 3/8] lib/lockref: __lockref_is_dead " Yaowei Bai
2017-12-12 2:55 ` [PATCH 4/8] kernel/cpuset: current_cpuset_is_being_rebound " Yaowei Bai
2017-12-12 2:55 ` [PATCH 5/8] kernel/resource: iomem_is_exclusive " Yaowei Bai
2017-12-12 2:55 ` [PATCH 6/8] kernel/module: module_is_live " Yaowei Bai
2017-12-12 2:55 ` [PATCH 7/8] kernel/mutex: mutex_is_locked " Yaowei Bai
2017-12-12 2:55 ` [PATCH 8/8] crash_dump: is_kdump_kernel " Yaowei Bai
2017-12-12 5:50 ` [PATCH 0/8] make some functions return bool David Rientjes
2017-12-12 7:21 ` Yaowei Bai
2017-12-12 8:12 ` Nikolay Borisov
2017-12-12 17:20 ` Randy Dunlap
2017-12-13 2:14 ` Yaowei Bai
2017-12-13 2:32 ` Randy Dunlap
2017-12-13 2:58 ` Yaowei Bai [this message]
2017-12-13 3:47 ` David Rientjes
2017-12-13 4:16 ` Yaowei Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213025804.GA21743@byw \
--to=baiyaowei@cmss.chinamobile.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox