From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752253AbdLMEQw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 23:16:52 -0500
Received: from cmccmta2.chinamobile.com ([221.176.66.80]:30136 "EHLO
        cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750749AbdLMEQt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 23:16:49 -0500
X-RM-TRANSID: 2ee85a30a9aeeb0-fd936
X-RM-TagInfo: emlType=0                                       
X-RM-SPAM-FLAG: 00000000
X-RM-TRANSID: 2ee85a30a9ae806-3a445
Date: Tue, 12 Dec 2017 23:16:41 -0500
From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: David Rientjes <rientjes@google.com>
Cc: Randy Dunlap <rdunlap@infradead.org>, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] make some functions return bool
Message-ID: <20171213041641.GA30654@byw>
Reply-To: baiyaowei@cmss.chinamobile.com
References: <1513047319-22302-1-git-send-email-baiyaowei@cmss.chinamobile.com>
 <alpine.DEB.2.10.1712112149010.56473@chino.kir.corp.google.com>
 <20171212072130.GA12496@byw>
 <0c71240b-ae6a-1233-3a59-e93081232823@infradead.org>
 <20171213021427.GB28668@byw>
 <81cc7b9e-8d3d-d529-7459-1d8a1e3baa65@infradead.org>
 <alpine.DEB.2.10.1712121946120.83765@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1712121946120.83765@chino.kir.corp.google.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 12, 2017 at 07:47:09PM -0800, David Rientjes wrote:
> On Tue, 12 Dec 2017, Randy Dunlap wrote:
> 
> > Sure, but I didn't keep the patch emails.
> > 
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > 
> 
> You may have noticed changing functions like is_file_lru() to bool when it 
> is used to index into an array or as part of an arithmetic operation for 

Yes, you're right. is_file_lru should not return bool. I'm using some
automitic ways to detect this type of functions. Pls ignore that patch
or i'll resend patchset without that one later. Thanks.

> ZVC stats.  I'm not sure why you would ack such code.