From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
openrisc@lists.librecores.org, linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH] openrisc: Fix conflicting types for _exext and _stext
Date: Wed, 13 Dec 2017 15:15:44 +0900 [thread overview]
Message-ID: <20171213061544.GA738@jagdpanzerIV> (raw)
In-Reply-To: <20171213034212.25910-1-joel@jms.id.au>
On (12/13/17 14:12), Joel Stanley wrote:
> The printk tree in linux-next has a patch "symbol lookup: introduce
> dereference_symbol_descriptor()" that includes sections.h in kallsyms.h,
> so arch/openrisc/kernel/traps.c gets a second extern definition for
> _etext and _stext.
>
> Remove the local definitions and include sections.h directly in
> preparation for the kallsyms.h change.
>
> This fixes the following (future) build error:
>
> CC arch/openrisc/kernel/traps.o
> arch/openrisc/kernel/traps.c:43:13: error: conflicting types for ‘_etext’
> extern char _etext, _stext;
> ^
> In file included from ./arch/openrisc/include/generated/asm/sections.h:1:0,
> from ./include/linux/kallsyms.h:15,
> from arch/openrisc/kernel/traps.c:35:
> ./include/asm-generic/sections.h:35:32: note: previous declaration of ‘_etext’ was here
> extern char _text[], _stext[], _etext[];
> ^
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
FWIW, looks good to me,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> ---
> arch/openrisc/kernel/traps.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/openrisc/kernel/traps.c b/arch/openrisc/kernel/traps.c
> index 4085d72fa5ae..5fb6d512502d 100644
> --- a/arch/openrisc/kernel/traps.c
> +++ b/arch/openrisc/kernel/traps.c
> @@ -39,8 +39,7 @@
> #include <asm/io.h>
> #include <asm/pgtable.h>
> #include <asm/unwinder.h>
> -
> -extern char _etext, _stext;
> +#include <asm/sections.h>
>
> int kstack_depth_to_print = 0x180;
> int lwa_flag;
> --
> 2.14.1
>
next prev parent reply other threads:[~2017-12-13 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 3:42 [PATCH] openrisc: Fix conflicting types for _exext and _stext Joel Stanley
2017-12-13 6:15 ` Sergey Senozhatsky [this message]
2017-12-13 14:53 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213061544.GA738@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=joel@jms.id.au \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=openrisc@lists.librecores.org \
--cc=pmladek@suse.com \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox