From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbdLMIjv (ORCPT ); Wed, 13 Dec 2017 03:39:51 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:56019 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdLMIju (ORCPT ); Wed, 13 Dec 2017 03:39:50 -0500 Date: Wed, 13 Dec 2017 09:39:46 +0100 From: Pavel Machek To: Sebastian Reichel Cc: "Andrew F. Davis" , pali.rohar@gmail.com, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net, martijn@brixit.nl, sakari.ailus@linux.intel.com, kernel@networkimprov.net, devicetree@vger.kernel.org, robh+dt@kernel.org Subject: Lithium battery protection was Re: [PATCH v4.14] Add support for bq27521 battery monitor Message-ID: <20171213083946.GA26605@amd> References: <20171109210615.GA27638@amd> <20171110103937.GA29900@amd> <20171201230649.GA27533@amd> <20171208170610.gbmlsgm7xzh2zpyn@earth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <20171208170610.gbmlsgm7xzh2zpyn@earth> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > >> This adds basic support for BQ27521 battery monitor, used in Nokia N9 > > >> and N950. In particular, battery voltage is important to be able to > > >> tell when the battery is almost empty. Emptying battery on N950 is > > >> pretty painful, as flasher needs to be used to recover phone in such > > >> case. > > >=20 > > > Sebastian, ping? This one should not be too controversial. > > > > Acked-by: Andrew F. Davis >=20 > Thanks, queued, I dropped the spurious change in twl.h and added the > dt-binding from the previous patch version, that was lost somehow. Thanks! > > > If you could also apply the "shut down when battery is low", that > > > would be nice. >=20 > I only have one with values specific to N900 hardcoded in the > driver. That one can't be applied for obvious reasons. Well... the values are not really N900-specific. They should work well on anything with lithium battery, because they basically depend only on battery chemistry. I guess I can simplify patch to work with battery voltage only -- that's what hardware battery protection does -- and make shutdown voltage configurable ...? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlow51IACgkQMOfwapXb+vI65gCfVHpJZZDo/CT/RcbN9geCaYOp ISgAnRm8ZFgsCjIjrJT4sd4hTE78eMCA =LGBd -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--