public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH 0/3] regmap: follow-up for ("regmap: allow to disable all locking mechanisms")
Date: Wed, 13 Dec 2017 10:28:09 +0100	[thread overview]
Message-ID: <20171213092812.26472-1-brgl@bgdev.pl> (raw)

Hi Mark,

this series is a follow-up for my previous patch. The first commit
renames the empty locking routine introduced in it - I agree with Andy
that it just looks better.

The second patch disables the debugfs entries when locking is disabled
as suggested by Lars-Peter.

The last patch is optional - feel free to drop it if you think it's not
necessary. I just noticed that most frameworks duplicate any name
strings, if it's possible that an unaware user gives us a pointer to
a temporary buffer. While I haven't found any such instance in the
current kernel, I believe it would make regmap safer for the future.

Bartosz Golaszewski (3):
  regmap: rename regmap_lock_unlock_empty() to regmap_lock_unlock_none()
  regmap: don't create the debugfs entries if locking is disabled
  regmap: duplicate the name string stored in regmap

 drivers/base/regmap/internal.h       |  2 ++
 drivers/base/regmap/regmap-debugfs.c |  5 +++++
 drivers/base/regmap/regmap.c         | 15 ++++++++++++---
 3 files changed, 19 insertions(+), 3 deletions(-)

-- 
2.15.1

             reply	other threads:[~2017-12-13  9:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  9:28 Bartosz Golaszewski [this message]
2017-12-13  9:28 ` [PATCH 1/3] regmap: rename regmap_lock_unlock_empty() to regmap_lock_unlock_none() Bartosz Golaszewski
2017-12-13  9:28 ` [PATCH 2/3] regmap: don't create the debugfs entries if locking is disabled Bartosz Golaszewski
2017-12-13 14:54   ` Andy Shevchenko
2017-12-13 14:59     ` Bartosz Golaszewski
2017-12-13 15:39   ` Mark Brown
2017-12-13 15:46     ` Bartosz Golaszewski
2017-12-13 16:00       ` Mark Brown
2017-12-13  9:28 ` [PATCH 3/3] regmap: duplicate the name string stored in regmap Bartosz Golaszewski
2017-12-13  9:32   ` Lars-Peter Clausen
2017-12-13  9:56     ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213092812.26472-1-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox