public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Mikhail Zaytsev <flashed@mail.ru>
Cc: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl
Date: Wed, 13 Dec 2017 12:24:45 +0100	[thread overview]
Message-ID: <20171213112445.GB3831@localhost> (raw)
In-Reply-To: <20171213123004.4619000a@zaytsev.tver.pg>

On Wed, Dec 13, 2017 at 12:30:04PM +0300, Mikhail Zaytsev wrote:
> The patch removes unused TIOCSSERIAL case from ioctl. TIOCGSERIAL case
>  moves to the get_serial_info() function. Some magic numbers moves to
>  #define directives.

You need to split logical changes up in separate patches, and there's at
least three things being done here.

Thanks,
Johan

  parent reply	other threads:[~2017-12-13 11:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  9:30 [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl Mikhail Zaytsev
2017-12-13 10:17 ` Oliver Neukum
2017-12-13 11:31   ` Mikhail Zaytsev
2017-12-13 11:40     ` Oliver Neukum
2017-12-13 12:30       ` Mikhail Zaytsev
2017-12-13 14:39         ` Oliver Neukum
2017-12-13 16:43           ` Mikhail Zaytsev
2017-12-13 11:24 ` Johan Hovold [this message]
2017-12-13 13:44   ` [PATCH 0/2] USB: serial: ark3116.c: ioctl changes Mikhail Zaytsev
2017-12-13 13:44   ` [PATCH 1/2] USB: serial: ark3116.c: Remove unused TIOCSSERIAL ioctl case Mikhail Zaytsev
2018-01-02 14:50     ` Johan Hovold
2017-12-13 13:45   ` [PATCH 2/2] USB: serial: ark3116.c: Move TIOCGSERIAL ioctl case to function Mikhail Zaytsev
2018-01-02 15:00     ` Johan Hovold
  -- strict thread matches above, loose matches on Subject: below --
2017-12-13  8:29 [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl Mikhail Zaytsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171213112445.GB3831@localhost \
    --to=johan@kernel.org \
    --cc=flashed@mail.ru \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox