From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Marek <marek_tomas@centrum.cz>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: pi433: fix brace coding style issues in pi433_if.c
Date: Wed, 13 Dec 2017 12:55:34 +0100 [thread overview]
Message-ID: <20171213115534.GA17402@kroah.com> (raw)
In-Reply-To: <1512852071-47406-1-git-send-email-marek_tomas@centrum.cz>
On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
> This patch fix several brace on next line, braces not necessary, space
> around =/<, and space before/after open/close parenthesis coding style
> errors find by checkpatch in pi433_if.c.
>
> Signed-off-by: Tomas Marek <marek_tomas@centrum.cz>
> ---
> Changes in v3:
> - DIO0_irq_handler update reverted - will be submitted in separate
> patch for the sake of clarity.
> Changes in v2:
> - DIO0_irq_handler updated - 'if/else if' replaced by 'switch' and
> 'dev_dbg_ratelimited' used instead of 'dev_dbg' according to Joe
> Perches suggestion.
> - The removal of braces around SET_CHECKED() reverted - caused syntax
> error and is addressed by another patch
> "[PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro".
This doesn't apply to my tree at all :(
Please rebase it against the staging-next branch of staging.git (or the
staging-testing branch to be sure), and then resend.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-13 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 20:41 [PATCH v3] Staging: pi433: fix brace coding style issues in pi433_if.c Tomas Marek
2017-12-13 11:55 ` Greg KH [this message]
2017-12-13 19:31 ` Tomas Marek
2017-12-14 7:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213115534.GA17402@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek_tomas@centrum.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox