From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752773AbdLMMHb (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 07:07:31 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:55218 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752584AbdLMMHa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 07:07:30 -0500
Date: Wed, 13 Dec 2017 13:07:33 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aniruddha Shastri <aniruddha.shastri@gmail.com>
Cc: devel@driverdev.osuosl.org,
        Christopher =?iso-8859-1?Q?M=E5rtensson?= <cribalik@gmail.com>,
        linux-kernel@vger.kernel.org, Ian Abbott <abbotti@mev.co.uk>,
        Saber Rezvani <irsaber@gmail.com>, Matthew Giassa <matthew@giassa.net>,
        Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH] staging: comedi: ni_*
Message-ID: <20171213120733.GA3402@kroah.com>
References: <1513159273-39619-1-git-send-email-aniruddha.shastri@gmail.com>
 <20171213105019.GA2546@kroah.com>
 <CANChdViW8N88-0oVWaehLR7MBNnJj9RCbQAEGU4f5oTca+NsYg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANChdViW8N88-0oVWaehLR7MBNnJj9RCbQAEGU4f5oTca+NsYg@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 13, 2017 at 05:16:13PM +0530, Aniruddha Shastri wrote:
> On Wed, Dec 13, 2017 at 4:20 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Dec 13, 2017 at 04:01:04AM -0600, Aniruddha Shastri wrote:
> > > Fix checkpatch warnings by shortening lines and reorganizing code where needed..
> > > Re-phrase the assert messages in ni_mio_common.c. This was done to meet the character limit for the message.
> >
> > And yet this line is over the character length :)
> Aniruddha: Thanks for pointing this out, I'll amend the commit message. :)

Why put your name in the response?  Of course I know it's you who is
writing this :)

> > >               range_table_list = kmalloc_array(32,
> > > -                                              sizeof(struct comedi_lrange *),
> > > +                                              range_size,
> >
> > Not worth changing.
> 
> Aniruddha: The original checkpatch.pl warning instructed to use
> const struct comedi_lrange instead of struct. Adding the 'const' put this
> line over the limit, so that's why I pulled it out into a local variable.

Checkpatch is a "hint", don't always follow it, it can cause some code
to look really bad.  It's not a hard-rule.

thanks,

greg k-h