From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Baolin Wang <baolin.wang@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-rtc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] rtc: Add tracepoints for RTC system
Date: Wed, 13 Dec 2017 13:23:29 +0100 [thread overview]
Message-ID: <20171213122329.GU8318@piout.net> (raw)
In-Reply-To: <20171213121603.GF6416@sirena.org.uk>
On 13/12/2017 at 12:16:03 +0000, Mark Brown wrote:
> On Wed, Dec 13, 2017 at 12:04:26PM +0100, Alexandre Belloni wrote:
>
> > Also, I think we could try having only the time64_t in the ring buffer.
> > Maybe I'm wrong but I think tools reading that buffer can do the
> > conversion themselves. Maybe I don't understand correctly how
> > tracepoints work and this doesn't make sense, tell me.
>
> Tools reading the buffer can do the conversion themselves but it's also
> useful for users to just view the log directly via tracing/trace
> sometimes. OTOH the whole point is to be low overhead so...
Yes, that is why I suggest keeping both representation in the printk
but only time64_t in the buffer. And this would be more convenient if we
add a way to pretty print a time64_t in vsprintf.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-13 12:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 5:59 [PATCH v2] rtc: Add tracepoints for RTC system Baolin Wang
2017-11-30 2:56 ` Baolin Wang
2017-12-12 22:16 ` Alexandre Belloni
2017-12-13 5:47 ` Baolin Wang
2017-12-13 8:33 ` Arnd Bergmann
2017-12-13 11:04 ` Alexandre Belloni
2017-12-13 12:16 ` Mark Brown
2017-12-13 12:23 ` Alexandre Belloni [this message]
2017-12-14 3:07 ` Baolin Wang
2017-12-13 16:46 ` Steven Rostedt
2017-12-13 16:45 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213122329.GU8318@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox