From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753731AbdLMRAx (ORCPT ); Wed, 13 Dec 2017 12:00:53 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58382 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753356AbdLMRAt (ORCPT ); Wed, 13 Dec 2017 12:00:49 -0500 Date: Wed, 13 Dec 2017 17:00:45 +0000 From: Mark Brown To: "Andrew F. Davis" Cc: Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header and switch to SPDX Message-ID: <20171213170045.GQ6416@sirena.org.uk> References: <20171212224311.24045-1-afd@ti.com> <20171213122824.GI6416@sirena.org.uk> <1ec05e88-b605-7ab4-ee5d-b3b73c562a0c@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V2tfspbppmK1TQo2" Content-Disposition: inline In-Reply-To: <1ec05e88-b605-7ab4-ee5d-b3b73c562a0c@ti.com> X-Cookie: Causes moderate eye irritation. User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --V2tfspbppmK1TQo2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 13, 2017 at 10:13:21AM -0600, Andrew F. Davis wrote: > My regex is a bit too rusty right now to handle searching for multi-line > examples, do you know of anyone else converting the whole block to C++ > style? > Things will look a lot uglier if we do this inconsistently, if it is now > the law of the land we do this for the first line, then we should have > it be the only exception. Everywhere else remaining old style comments, > IMHO. I think that's just the limited tooling people are using right now, we'll need to clean up the automatically generated output. Unless people provide tools to enforce styles we're going to end up with divergence anyway as people start adding new files, they ought to be going in with SPDX headers. --V2tfspbppmK1TQo2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAloxXLwACgkQJNaLcl1U h9CT/gf/SNJYZjs4U8PKduE/1GU8YaDYDPj/ioL9aMt7/sy5xKsZl7hMPUZnjGDr w66tld+P2z4G+lk+ZuOVec/i/hXvaxtdxk3jp9SV+BqUqS741ARTx9qr4Mv0GWsr VPZ5nUkufTABHrUWNU5FBUPmh1Uy9KVuKH42DuXwadMEVLWZxhR1ypnDIMvK7s3B f0dwujyDD2kNUYE5+CUNeQSXuWMKUuB6uxcTWBRz2edF7ARokhJ+Ho9OFG+7ymIv 4v9C/7g7Euz+wI+EZMzVKc9fLIjchixTQVzINofe8IN77+YqEf4LhMdEFz/5bcFk 1eoEOjjot/2PIF5o6Yud1ZT4NR5JWQ== =cisq -----END PGP SIGNATURE----- --V2tfspbppmK1TQo2--