Re: [PATCH v5 4/9] drivers: base cacheinfo: Add support for ACPI based firmware tables

Sudeep Holla
2018-01-04T11:46:58Z

On 03/01/18 14:21, Sudeep Holla wrote:
> On 12/12/17 23:37, Jeremy Linton wrote:
>> On 12/12/2017 05:02 PM, Rafael J. Wysocki wrote:
>
> [...]
>
>>>
>>> So call this field "token" or similar.  Don't call it "of_node" and
>>> don't introduce another "firmware_node" thing in addition to that.
>>> That just is a mess, sorry.
>
> I completely agree. Both me and Lorenzo pointed that out in previous
> revisions and fair enough you have a valid concern it's use with PPTT.
>
>>
>> I sort of agree, I think I can just change the whole of_node to a
>> generic 'void *firmware_unique' which works fine for the PPTT code, it
>> should also work for the DT code in cache_leaves_are_shared().
>>
>
> Should be fine.
>

Just to let you know, I don't have much to add. I will wait for the
patches that replace of_node with firmware cookie or something similar.
--
Regards,
Sudeep