From: Jason Gunthorpe <jgg@ziepe.ca>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Steve Wise <swise@chelsio.com>,
Doug Ledford <dledford@redhat.com>,
Bharat Potnuri <bharat@chelsio.com>,
Leon Romanovsky <leon@kernel.org>,
Ganesh Goudar <ganeshgr@chelsio.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: infiniband: cxgb4: use ktime_get for timestamps
Date: Wed, 13 Dec 2017 11:19:06 -0700 [thread overview]
Message-ID: <20171213181906.GA5984@ziepe.ca> (raw)
In-Reply-To: <20171127114518.2662754-1-arnd@arndb.de>
On Mon, Nov 27, 2017 at 12:44:53PM +0100, Arnd Bergmann wrote:
> The debugfs file prints the difference between host timestamps as a
> seconds/nanoseconds tuple, along with a 64-bit nanoseconds hardware
> timestamp. The host time is read using getnstimeofday() which is
> deprecated because of the y2038 overflow, and it suffers from time jumps
> during settimeofday() and leap seconds.
>
> Converting to ktime_get_ts64() would solve those two, but I'm going
> a little further here by changing to ktime_get() and printing 64-bit
> nanoseconds on both host and hw timestamps. This simplifies the code
> further and makes the output easier to understand.
>
> The format of the debugfs file obviously changes here, but this should
> only be read by humans and not scripts, so I assume it's fine.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Steve Wise <swise@opengridcomputing.com>
> drivers/infiniband/hw/cxgb4/device.c | 34 +++++++++++++++-------------------
> drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 4 ++--
> drivers/infiniband/hw/cxgb4/qp.c | 6 +++---
> drivers/infiniband/hw/cxgb4/t4.h | 4 ++--
> 4 files changed, 22 insertions(+), 26 deletions(-)
Thanks, applied to -next
Jason
prev parent reply other threads:[~2017-12-13 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 11:44 [PATCH] infiniband: cxgb4: use ktime_get for timestamps Arnd Bergmann
2017-12-11 22:56 ` Jason Gunthorpe
2017-12-11 23:02 ` Steve Wise
2017-12-13 18:19 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171213181906.GA5984@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=arnd@arndb.de \
--cc=bharat@chelsio.com \
--cc=dledford@redhat.com \
--cc=ganeshgr@chelsio.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox