From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751049AbdLNH3I (ORCPT ); Thu, 14 Dec 2017 02:29:08 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54792 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbdLNH3H (ORCPT ); Thu, 14 Dec 2017 02:29:07 -0500 Date: Thu, 14 Dec 2017 08:29:11 +0100 From: Greg KH To: Tomas Marek Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] Staging: pi433: fix brace coding style issues in pi433_if.c Message-ID: <20171214072911.GE27027@kroah.com> References: <1512852071-47406-1-git-send-email-marek_tomas@centrum.cz> <20171213115534.GA17402@kroah.com> <29ec3534-467a-de55-46a0-1c16c335bee1@centrum.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29ec3534-467a-de55-46a0-1c16c335bee1@centrum.cz> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 11:31:15AM -0800, Tomas Marek wrote: > On 12/13/2017 03:55 AM, Greg KH wrote: > > > On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote: > >> This patch fix several brace on next line, braces not necessary, space > >> around =/<, and space before/after open/close parenthesis coding style > >> errors find by checkpatch in pi433_if.c. > >> > >> Signed-off-by: Tomas Marek > >> --- > >> Changes in v3: > >> - DIO0_irq_handler update reverted - will be submitted in separate > >> patch for the sake of clarity. > >> Changes in v2: > >> - DIO0_irq_handler updated - 'if/else if' replaced by 'switch' and > >> 'dev_dbg_ratelimited' used instead of 'dev_dbg' according to Joe > >> Perches suggestion. > >> - The removal of braces around SET_CHECKED() reverted - caused syntax > >> error and is addressed by another patch > >> "[PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro". > > This doesn't apply to my tree at all :( > > > > Please rebase it against the staging-next branch of staging.git (or the > > staging-testing branch to be sure), and then resend. > > > > thanks, > > > > greg k-h > I am sorry for complications. I did it against linux-next. I'll rebase it > against stating and cross-check against staging-testing, hopefully it will > be fine then. Normally linux-next is fine to do your work against. But as you can see on the mailing list, there are a lot of people sending a lot of patches for this one driver. So things end up changing quickly, usually the merge issue is that I took a patch that was sent a few hours before yours, and you did it all right. Sorry, rebasing and resending patches are just a normal mode for working on a high-traffic area in the kernel, thanks for your patience. greg k-h