[PATCH v2 1/2] leds: as3645a: Fix quoted string split warning

[PATCH v2 1/2] leds: as3645a: Fix quoted string split warning

[Dan Murphy]

Fix a warning for a split quoted string across
lines.

WARNING: quoted string split across lines
459: FILE: drivers/leds/leds-as3645a.c:459:
		dev_err(dev, "AS3645A not detected "
			"(model %d rfu %d)\n", model, rfu);

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v2 - Split the warning fixes into 2 patches and fixed commit message -
https://patchwork.kernel.org/patch/10108325/

 drivers/leds/leds-as3645a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index 9a257f969300..49fdd7c0a6f6 100644
--- a/drivers/leds/leds-as3645a.c
+++ b/drivers/leds/leds-as3645a.c
@@ -455,8 +455,8 @@ static int as3645a_detect(struct as3645a *flash)
 
 	/* Verify the chip model and version. */
 	if (model != 0x01 || rfu != 0x00) {
-		dev_err(dev, "AS3645A not detected "
-			"(model %d rfu %d)\n", model, rfu);
+		dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
+			model, rfu);
 		return -ENODEV;
 	}
 
-- 
2.15.0.124.g7668cbc60

[PATCH v2 2/2] leds: as3645a: Fix line over 80 characters

[Dan Murphy]

Fix the warning for line over 80 characters.

WARNING: line over 80 characters
363: FILE: drivers/leds/leds-as3645a.c:363:
	flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---

v2 - Split the warning fixes into 2 patches and fixed commit message - 
https://patchwork.kernel.org/patch/10108325/

 drivers/leds/leds-as3645a.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
index 49fdd7c0a6f6..f883616d9e60 100644
--- a/drivers/leds/leds-as3645a.c
+++ b/drivers/leds/leds-as3645a.c
@@ -360,7 +360,8 @@ static int as3645a_set_flash_brightness(struct led_classdev_flash *fled,
 {
 	struct as3645a *flash = fled_to_as3645a(fled);
 
-	flash->flash_current = as3645a_current_to_reg(flash, true, brightness_ua);
+	flash->flash_current = as3645a_current_to_reg(flash, true,
+						      brightness_ua);
 
 	return as3645a_set_current(flash);
 }
-- 
2.15.0.124.g7668cbc60

Re: [PATCH v2 1/2] leds: as3645a: Fix quoted string split warning

[Sakari Ailus]

On Thu, Dec 14, 2017 at 11:37:26AM -0600, Dan Murphy wrote:
> Fix a warning for a split quoted string across
> lines.
> 
> WARNING: quoted string split across lines
> 459: FILE: drivers/leds/leds-as3645a.c:459:
> 		dev_err(dev, "AS3645A not detected "
> 			"(model %d rfu %d)\n", model, rfu);
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Thanks!

For both:

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi

Re: [PATCH v2 1/2] leds: as3645a: Fix quoted string split warning

[Jacek Anaszewski]

Hi Dan,

Thanks for the patch set.
Bot patches applied to the for-next branch.

-- 
Best regards,
Jacek Anaszewski

On 12/14/2017 06:37 PM, Dan Murphy wrote:
> Fix a warning for a split quoted string across
> lines.
> 
> WARNING: quoted string split across lines
> 459: FILE: drivers/leds/leds-as3645a.c:459:
> 		dev_err(dev, "AS3645A not detected "
> 			"(model %d rfu %d)\n", model, rfu);
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> 
> v2 - Split the warning fixes into 2 patches and fixed commit message -
> https://patchwork.kernel.org/patch/10108325/
> 
>  drivers/leds/leds-as3645a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index 9a257f969300..49fdd7c0a6f6 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -455,8 +455,8 @@ static int as3645a_detect(struct as3645a *flash)
>  
>  	/* Verify the chip model and version. */
>  	if (model != 0x01 || rfu != 0x00) {
> -		dev_err(dev, "AS3645A not detected "
> -			"(model %d rfu %d)\n", model, rfu);
> +		dev_err(dev, "AS3645A not detected (model %d rfu %d)\n",
> +			model, rfu);
>  		return -ENODEV;
>  	}
>  
>