From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbdLOFak (ORCPT ); Fri, 15 Dec 2017 00:30:40 -0500 Received: from mga03.intel.com ([134.134.136.65]:52532 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbdLOFag (ORCPT ); Fri, 15 Dec 2017 00:30:36 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,403,1508828400"; d="scan'208";a="186879596" Date: Fri, 15 Dec 2017 11:04:23 +0530 From: Vinod Koul To: Pierre-Louis Bossart Cc: alsa-devel@kernel.org, tiwai@suse.de, broonie@kernel.org, torvalds@linux-foundation.org, liam.r.girdwood@linux.intel.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/9] ASoC: Intel: Kconfig fixes Message-ID: <20171215053423.GD18649@localhost> References: <20171215004451.30800-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171215004451.30800-1-pierre-louis.bossart@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 14, 2017 at 06:44:42PM -0600, Pierre-Louis Bossart wrote: > The first patch implements what Linus, Takashi and Mark > requested: a top-level selector defaulting to 'y' to easily filter all > other options and with no impact on code generation. There should be no > functionality change and will avoid breaking audio for people using > make oldnoconfig. > > The rest of the patch series does a more in-depth cleanup. It was tested > on Baytrail/Cherrytrail/Skylake platforms with no regressions > observed and no reports of any compilation issues with 0-day or > randconfig. > > The 4th patch is really the most important one, there were nested > configs which made no sense to me. I don't know the history which led > to such complicated stuff but simpler is better. > > Patches 5..7 are just clean-ups of the machine driver configs, > for some reason there is no consistency in the settings so I tried to > apply common sense and use the same rules. At Andy Shevchenko's suggestion, > I also replaced the broken dependency on X86_INTEL_LPSS by MFD_INTEL_LPSS > for Skylake+ machines. No regressions were identified with this change. > > Patches 8 and 9 are new in this series and are just cosmetic changes (comments > and text simplification). > > Thanks to Vinod Koul for his contributions and comments. > > Changes since RFCv2: > Moved machine drivers to submenu > Dropped SND_SOC_INTEL_COMMON since it was not needed > Added more comments for if/endif > Simplified text for options (dropped "ASoC Intel driver....") > Fixed one 0-day warning > > Changes since initial RFC: > Removed default n > Added help text for HASWELL, BAYTRAIL (legacy) and SKYLAKE options > Made top level machine driver selection dependent on INTEL_SST_TOPLEVEL. > Added help text for PCI and HIFI2 platforms > Replaced X86_INTEL_LPSS by MFD_INTEL_LPSS for Skylake+ devices > Fixed a couple of indentation issues For these: > Pierre-Louis Bossart (7): > ASoC: Intel: Fix Kconfig with top-level selector > ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies > ASoC: Intel: document what Kconfig options do > ASoC: Intel: Fix nested/unnecessary Kconfig dependencies > ASoC: Intel: boards: align Kconfig dependencies for Haswell/Broadwell > ASoC: Intel: boards: align Kconfig configurations for HiFi2 > ASoC: Intel: boards: align/fix SKL/BXT/KBL Kconfigs Acked-By: Vinod Koul -- ~Vinod