From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755170AbdLOJJK (ORCPT ); Fri, 15 Dec 2017 04:09:10 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:44054 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754784AbdLOJJF (ORCPT ); Fri, 15 Dec 2017 04:09:05 -0500 Date: Fri, 15 Dec 2017 10:09:03 +0100 From: Pavel Machek To: Dan Murphy Cc: robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net, jacek.anaszewski@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v4 4/6] dt: bindings: lp8860: Add trigger binding to the lp8860 Message-ID: <20171215090903.GC8221@amd> References: <20171212220143.31210-1-dmurphy@ti.com> <20171212220143.31210-5-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: <20171212220143.31210-5-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > @@ -35,6 +37,7 @@ led-controller@2d { > led@0 { > reg =3D <0>; > label =3D "white:display_cluster"; > + linux,default-trigger =3D "backlight"; > }; > } What is "display_cluster"? Is it display backlight? Could we use ":backlight" and perhaps start documentation file listing "common" LED descriptions so they are shared across machines? For the record, I'd prefer this to be "/sys/class/leds/display:white:backlight" in the end... so that we have nice naming for userspace, consistent between different machines. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlozkS8ACgkQMOfwapXb+vLIRwCeP1awOlpae6487YFuMV/XeTAQ DpkAn2dgch5hKKuHhI+FyUKd8b9MtN1G =IDp/ -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA--