From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756039AbdLOSoW (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 13:44:22 -0500
Received: from mga12.intel.com ([192.55.52.136]:55761 "EHLO mga12.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755530AbdLOSoU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 13:44:20 -0500
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,406,1508828400"; 
   d="scan'208";a="1997851"
Date: Fri, 15 Dec 2017 20:39:54 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] gpio: fix "gpio-line-names" property retrieval
Message-ID: <20171215183954.GJ22431@lahna.fi.intel.com>
References: <20171215140233.804E768968@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171215140233.804E768968@localhost.localdomain>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 15, 2017 at 03:02:33PM +0100, Christophe Leroy wrote:
> Following commit 9427ecbed46cc ("gpio: Rework of_gpiochip_set_names()
> to use device property accessors"), "gpio-line-names" DT property is
> not retrieved anymore when chip->parent is not set by the driver.
> This is due to OF based property reads having been replaced by device
> based property reads.
> 
> This patch fixes that by making use of
> fwnode_property_read_string_array() instead of
> device_property_read_string_array() and handing over either
> of_fwnode_handle(chip->of_node) or dev_fwnode(chip->parent)
> to that function.
> 
> Fixes: 9427ecbed46cc ("gpio: Rework of_gpiochip_set_names() to use device property accessors")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>