From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756808AbdLPEzu (ORCPT ); Fri, 15 Dec 2017 23:55:50 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:44274 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756380AbdLPEzt (ORCPT ); Fri, 15 Dec 2017 23:55:49 -0500 X-Google-Smtp-Source: ACJfBos/M7n4IyqEdPWy1Mk68ayQEI6v8KGo0x+OhFbqFABShXsuO6p+vyy6e9I1lrvEY0QR2vKSGg== Date: Fri, 15 Dec 2017 20:55:44 -0800 From: Brian Norris To: Enric Balletbo i Serra , Alessandro Zummo , Alexandre Belloni Cc: Lee Jones , bleung@chromium.org, Guenter Roeck , Gwendal Grignou , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Stephen Barber Subject: Re: [PATCH v4 1/2] mfd: cros_ec: Introduce RTC commands and events definitions. Message-ID: <20171216045542.GA52366@google.com> References: <20171110215553.20696-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171110215553.20696-2-enric.balletbo@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Nov 10, 2017 at 10:55:52PM +0100, Enric Balletbo i Serra wrote: > From: Stephen Barber > > The EC can function as a simple RT, this patch adds the RTC related > definitions needed by the rtc-cros-ec driver. > > Signed-off-by: Stephen Barber > Signed-off-by: Enric Balletbo i Serra > Acked-by: Lee Jones > Acked-by: Benson Leung Reviewed-by: Brian Norris I guess this is waiting to get merged by an RTC maintainer, since it's a dependency for the RTC driver in patch 2? Alessandro or Alexandre, any thoughts? Brian > --- > include/linux/mfd/cros_ec_commands.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h > index 2b16e95..c6046a2 100644 > --- a/include/linux/mfd/cros_ec_commands.h > +++ b/include/linux/mfd/cros_ec_commands.h > @@ -291,6 +291,9 @@ enum host_event_code { > /* EC desires to change state of host-controlled USB mux */ > EC_HOST_EVENT_USB_MUX = 28, > > + /* EC RTC event occurred */ > + EC_HOST_EVENT_RTC = 26, > + > /* > * The high bit of the event mask is not used as a host event code. If > * it reads back as set, then the entire event mask should be > @@ -799,6 +802,8 @@ enum ec_feature_code { > EC_FEATURE_USB_MUX = 23, > /* Motion Sensor code has an internal software FIFO */ > EC_FEATURE_MOTION_SENSE_FIFO = 24, > + /* EC has RTC feature that can be controlled by host commands */ > + EC_FEATURE_RTC = 27, > }; > > #define EC_FEATURE_MASK_0(event_code) (1UL << (event_code % 32)) > @@ -1709,6 +1714,9 @@ struct ec_response_rtc { > #define EC_CMD_RTC_SET_VALUE 0x46 > #define EC_CMD_RTC_SET_ALARM 0x47 > > +/* Pass as param to SET_ALARM to clear the current alarm */ > +#define EC_RTC_ALARM_CLEAR 0 > + > /*****************************************************************************/ > /* Port80 log access */ >