From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440AbdLRENX (ORCPT ); Sun, 17 Dec 2017 23:13:23 -0500 Received: from mga17.intel.com ([192.55.52.151]:51619 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932212AbdLRENV (ORCPT ); Sun, 17 Dec 2017 23:13:21 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,420,1508828400"; d="scan'208";a="187879283" Date: Mon, 18 Dec 2017 09:47:11 +0530 From: Vinod Koul To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com, joabreu@synopsys.com, mike.looijmans@topic.nl, kedare06@gmail.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/6] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor Message-ID: <20171218041711.GN18649@localhost> References: <1512624067-13554-1-git-send-email-appanad@xilinx.com> <1512624067-13554-2-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512624067-13554-2-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 07, 2017 at 10:51:02AM +0530, Kedareswara rao Appana wrote: > @@ -2029,6 +2006,7 @@ static int xilinx_dma_terminate_all(struct dma_chan *dchan) > > /* Remove and free all of the descriptors in the lists */ > xilinx_dma_free_descriptors(chan); > + chan->idle = true; > > if (chan->cyclic) { > reg = dma_ctrl_read(chan, XILINX_DMA_REG_DMACR); > @@ -2344,6 +2322,12 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev, > chan->has_sg = xdev->has_sg; > chan->desc_pendingcount = 0x0; > chan->ext_addr = xdev->ext_addr; > + /* This variable enusres that descripotrs are not ^^^^^^^^^^ typo -- ~Vinod