* [PATCH V2] hyper-v: use GFP_KERNEL for hv_context.hv_numa_map
@ 2017-12-18 9:02 Jia-Ju Bai
2017-12-18 17:05 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Jia-Ju Bai @ 2017-12-18 9:02 UTC (permalink / raw)
To: kys, haiyangz, sthemmin; +Cc: devel, linux-kernel, Jia-Ju Bai
The kzalloc function is called with GFP_ATOMIC.
But according to driver call graph, it is not in atomic context,
namely no spinlock is held nor in an interrupt handler.
This GFP_ATOMIC is unnecessary, and replace with GFP_KERNEL.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/hv/hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 8267439..b0d025a 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -150,7 +150,7 @@ int hv_synic_alloc(void)
int cpu;
hv_context.hv_numa_map = kzalloc(sizeof(struct cpumask) * nr_node_ids,
- GFP_ATOMIC);
+ GFP_KERNEL);
if (hv_context.hv_numa_map == NULL) {
pr_err("Unable to allocate NUMA map\n");
goto err;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2] hyper-v: use GFP_KERNEL for hv_context.hv_numa_map
2017-12-18 9:02 [PATCH V2] hyper-v: use GFP_KERNEL for hv_context.hv_numa_map Jia-Ju Bai
@ 2017-12-18 17:05 ` Stephen Hemminger
2017-12-19 8:40 ` Jia-Ju Bai
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2017-12-18 17:05 UTC (permalink / raw)
To: Jia-Ju Bai; +Cc: kys, haiyangz, sthemmin, devel, linux-kernel
On Mon, 18 Dec 2017 17:02:52 +0800
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> The kzalloc function is called with GFP_ATOMIC.
> But according to driver call graph, it is not in atomic context,
> namely no spinlock is held nor in an interrupt handler.
>
> This GFP_ATOMIC is unnecessary, and replace with GFP_KERNEL.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
> drivers/hv/hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index 8267439..b0d025a 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -150,7 +150,7 @@ int hv_synic_alloc(void)
> int cpu;
>
> hv_context.hv_numa_map = kzalloc(sizeof(struct cpumask) * nr_node_ids,
> - GFP_ATOMIC);
> + GFP_KERNEL);
> if (hv_context.hv_numa_map == NULL) {
> pr_err("Unable to allocate NUMA map\n");
> goto err;
Thanks, for fixing this.
While you are at it; wouldn't it make sense to use kcalloc here?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V2] hyper-v: use GFP_KERNEL for hv_context.hv_numa_map
2017-12-18 17:05 ` Stephen Hemminger
@ 2017-12-19 8:40 ` Jia-Ju Bai
0 siblings, 0 replies; 3+ messages in thread
From: Jia-Ju Bai @ 2017-12-19 8:40 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: kys, haiyangz, sthemmin, devel, linux-kernel
On 2017/12/19 1:05, Stephen Hemminger wrote:
> On Mon, 18 Dec 2017 17:02:52 +0800
> Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>
>> The kzalloc function is called with GFP_ATOMIC.
>> But according to driver call graph, it is not in atomic context,
>> namely no spinlock is held nor in an interrupt handler.
>>
>> This GFP_ATOMIC is unnecessary, and replace with GFP_KERNEL.
>>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
>> ---
>> drivers/hv/hv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
>> index 8267439..b0d025a 100644
>> --- a/drivers/hv/hv.c
>> +++ b/drivers/hv/hv.c
>> @@ -150,7 +150,7 @@ int hv_synic_alloc(void)
>> int cpu;
>>
>> hv_context.hv_numa_map = kzalloc(sizeof(struct cpumask) * nr_node_ids,
>> - GFP_ATOMIC);
>> + GFP_KERNEL);
>> if (hv_context.hv_numa_map == NULL) {
>> pr_err("Unable to allocate NUMA map\n");
>> goto err;
> Thanks, for fixing this.
> While you are at it; wouldn't it make sense to use kcalloc here?
I think kcalloc can be used here.
Thanks,
Jia-Ju Bai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-19 8:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-18 9:02 [PATCH V2] hyper-v: use GFP_KERNEL for hv_context.hv_numa_map Jia-Ju Bai
2017-12-18 17:05 ` Stephen Hemminger
2017-12-19 8:40 ` Jia-Ju Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox