From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758600AbdLRL6W (ORCPT ); Mon, 18 Dec 2017 06:58:22 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54495 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758497AbdLRL6U (ORCPT ); Mon, 18 Dec 2017 06:58:20 -0500 Date: Mon, 18 Dec 2017 12:58:18 +0100 From: Pavel Machek To: "Neftin, Sasha" , jacob.e.keller@intel.com Cc: David Miller , bpoirier@suse.com, nix.or.die@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, lsorense@csclub.uwaterloo.ca Subject: Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working Message-ID: <20171218115817.GA17054@amd> References: <20171210083949.GA3872@amd> <20171215092849.GB15090@amd> <20171215.105210.103516329605719086.davem@davemloft.net> <20171218102657.GB5338@amd> <5c0be4c4-5a56-cc7b-7b5a-345f446e788e@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <5c0be4c4-5a56-cc7b-7b5a-345f446e788e@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2017-12-18 13:24:40, Neftin, Sasha wrote: > On 12/18/2017 12:26, Pavel Machek wrote: > >Hi! > > > >>>>>In v4.15-rc2+, network manager can not see my ethernet card, and > >>>>>manual attempts to ifconfig it up did not really help, either. > >>>>> > >>>>>Card is: > >>>>> > >>>>>02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethern= et > >>>>>Controller > >>>.... > >>>>>Any ideas ? > >>>>Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it. > >>>> > >>>>See: > >>>>https://bugzilla.kernel.org/show_bug.cgi?id=3D198047 > >>>> > >>>>Fix there : > >>>>https://marc.info/?l=3Dlinux-kernel&m=3D151272209903675&w=3D2 > >>>I don't see the patch in latest mainline. Not having ethernet > >>>is... somehow annoying. What is going on there? > >>Generally speaking, e1000 maintainence has been handled very poorly over > >>the past few years, I have to say. > >> > >>Fixes take forever to propagate even when someone other than the > >>maintainer provides a working and tested fix, just like this case. > >> > >>Jeff, please take e1000 maintainence seriously and get these critical > >>bug fixes propagated. > >No response AFAICT. I guess I should test reverting > >19110cfbb34d4af0cdfe14cd243f3b09dc95b013, then ask you for revert? >=20 > Hello Pavel, >=20 > Before ask for reverting 19110cfbb..., please, check if follow patch of > Benjamin work for you http://patchwork.ozlabs.org/patch/846825/ Jacob said, in another email: # Digging into this, the problem is complicated. The original bug # assumed behavior of the .check_for_link call, which is universally not # implemented. #=20 # I think the correct fix is to revert 19110cfbb34d ("e1000e: Separate # signaling for link check/link up", 2017-10-10) and find a more proper sol= ution. =2E..which makes me think that revert is preffered? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlo3rVkACgkQMOfwapXb+vKUswCffsIBTt9MG+k5sYxNa3zpQLu2 negAn2LbRFOseLJAhgZxjHxTBw+H0jI2 =PSo8 -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--