[linux-next:master 5061/5571] fs/cifs/smbdirect.c:1465:24: sparse: symbol '_smbd_get_connection' was not declared. Should it be static?

[linux-next:master 5061/5571] fs/cifs/smbdirect.c:1465:24: sparse: symbol '_smbd_get_connection' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   53600ecfb6004f355bd3551bee180caf4b42d7a7
commit: 07495ff5d9bc753b5cc4cd26c355bf186e865892 [5061/5571] CIFS: SMBD: Establish SMB Direct connection
reproduce:
        # apt-get install sparse
        git checkout 07495ff5d9bc753b5cc4cd26c355bf186e865892
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)


Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH linux-next] CIFS: SMBD: _smbd_get_connection() can be static

[kbuild test robot]

Fixes: 07495ff5d9bc ("CIFS: SMBD: Establish SMB Direct connection")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 smbdirect.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c
index 2ecd5c1..62a5c3f 100644
--- a/fs/cifs/smbdirect.c
+++ b/fs/cifs/smbdirect.c
@@ -1462,7 +1462,7 @@ static int allocate_caches_and_workqueue(struct smbd_connection *info)
 }
 
 /* Create a SMBD connection, called by upper layer */
-struct smbd_connection *_smbd_get_connection(
+static struct smbd_connection *_smbd_get_connection(
 	struct TCP_Server_Info *server, struct sockaddr *dstaddr, int port)
 {
 	int rc;

RE: [RFC PATCH linux-next] CIFS: SMBD: _smbd_get_connection() can be static

[Long Li]

> Fixes: 07495ff5d9bc ("CIFS: SMBD: Establish SMB Direct connection")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Long Li <longli@microsoft.com>

Thanks.

> ---
>  smbdirect.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c index 2ecd5c1..62a5c3f
> 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -1462,7 +1462,7 @@ static int allocate_caches_and_workqueue(struct
> smbd_connection *info)  }
> 
>  /* Create a SMBD connection, called by upper layer */ -struct
> smbd_connection *_smbd_get_connection(
> +static struct smbd_connection *_smbd_get_connection(
>  	struct TCP_Server_Info *server, struct sockaddr *dstaddr, int port)  {
>  	int rc;

Re: [RFC PATCH linux-next] CIFS: SMBD: _smbd_get_connection() can be static

[Steve French]

merged into cifs-2.6.git for-next thx

On Mon, Dec 18, 2017 at 7:30 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
>
> Fixes: 07495ff5d9bc ("CIFS: SMBD: Establish SMB Direct connection")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  smbdirect.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smbdirect.c b/fs/cifs/smbdirect.c
> index 2ecd5c1..62a5c3f 100644
> --- a/fs/cifs/smbdirect.c
> +++ b/fs/cifs/smbdirect.c
> @@ -1462,7 +1462,7 @@ static int allocate_caches_and_workqueue(struct smbd_connection *info)
>  }
>
>  /* Create a SMBD connection, called by upper layer */
> -struct smbd_connection *_smbd_get_connection(
> +static struct smbd_connection *_smbd_get_connection(
>         struct TCP_Server_Info *server, struct sockaddr *dstaddr, int port)
>  {
>         int rc;



-- 
Thanks,

Steve