Re: [PATCH 4.4 045/115] sched/deadline: Throttle a constrained deadline task activated after the deadline

Greg Kroah-Hartman
2018-01-19T07:53:07Z

On Fri, Jan 19, 2018 at 01:00:45AM +0000, Ben Hutchings wrote:
> On Mon, 2017-12-18 at 16:48 +0100, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me
> > know.
> >
> > ------------------
> >
> > From: Daniel Bristot de Oliveira <bristot@redhat.com>
> >
> >
> > [ Upstream commit df8eac8cafce7d086be3bd5cf5a838fa37594dfb ]
> [...]
>
> I think this needs another fix on top:
>
> commit ae83b56a56f8d9643dedbee86b457fa1c5d42f59
> Author: Xunlei Pang <xlpang@redhat.com>
> Date:   Wed May 10 21:03:37 2017 +0800
>
>     sched/deadline: Zero out positive runtime after throttling constrained tasks

Now queued up, thanks.

> There's another fix related to this, but it doesn't appear to fix a
> regression and I don't know how critical it is:
>
> commit 3effcb4247e74a51f5d8b775a1ee4abf87cc089a
> Author: Daniel Bristot de Oliveira <bristot@redhat.com>
> Date:   Mon May 29 16:24:03 2017 +0200
>
>     sched/deadline: Use the revised wakeup rule for suspending constrained dl tasks

I'll hold off on this one until someone actually asks for it, as it's a
big change.

thanks again for the review,

greg k-h