From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933617AbdLRTDJ (ORCPT ); Mon, 18 Dec 2017 14:03:09 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:54710 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759773AbdLRTDF (ORCPT ); Mon, 18 Dec 2017 14:03:05 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8EC0160376 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 18 Dec 2017 11:03:03 -0800 From: Stephen Boyd To: Jerome Brunet Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: check ops pointer on clock register Message-ID: <20171218190303.GV7997@codeaurora.org> References: <20171218170007.28042-1-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171218170007.28042-1-jbrunet@baylibre.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18, Jerome Brunet wrote: > Nothing really prevents a provider from (trying to) register a clock > without providing the clock ops structure. > > We do check the individual fields before using them, but not the > structure pointer itself. This may have the usual nasty consequences when > the pointer is dereferenced, mostly likely when checking one the field > during the initialization. Yes, that nasty consequence should be a kernel oops, and the developer should notice that before submitting the driver for inclusion. I don't think we really care to return an error here if this happens. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project