From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Rohloff <v10lator@myway.de>
Cc: Jiri Slaby <jslaby@suse.com>, Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tty: serial: meson: allow baud-rates lower than 9600
Date: Tue, 19 Dec 2017 09:56:38 +0100 [thread overview]
Message-ID: <20171219085638.GA21577@kroah.com> (raw)
In-Reply-To: <7cf5ad02-6003-4222-a2cb-030ae613b337@myway.de>
On Sat, Nov 04, 2017 at 01:36:07PM +0100, Thomas Rohloff wrote:
> Devices like DCF77 receivers need the baud-rate to be as low as 50.
>
> I have tested this on a Meson GXL device with uart_A.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Carlo Caione <carlo@caione.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Thomas Rohloff <v10lator@myway.de>
> ---
> drivers/tty/serial/meson_uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/meson_uart.c
> b/drivers/tty/serial/meson_uart.c
> index 07c0f98be3ac..e281ce5d101d 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -362,7 +362,7 @@ static void meson_uart_set_termios(struct uart_port
> *port,
>
> writel(val, port->membase + AML_UART_CONTROL);
>
> - baud = uart_get_baud_rate(port, termios, old, 9600, 4000000);
> + baud = uart_get_baud_rate(port, termios, old, 50, 4000000);
> meson_uart_change_speed(port, baud);
>
> port->read_status_mask = AML_UART_TX_FIFO_WERR;
This patch is corrupted (line-wrapped), and can not be applied. Please
fix up and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-19 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 12:36 [PATCH v3] tty: serial: meson: allow baud-rates lower than 9600 Thomas Rohloff
2017-12-19 8:56 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-11-04 13:00 V10lator
2017-11-04 13:13 ` Greg Kroah-Hartman
2017-11-04 16:44 ` Neil Armstrong
2017-11-05 4:26 ` V10lator
2017-11-05 7:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219085638.GA21577@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=carlo@caione.org \
--cc=jslaby@suse.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=v10lator@myway.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox