* [PATCH] misc: mic: remove unused label
@ 2017-12-15 12:47 Arnd Bergmann
2017-12-19 9:53 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-12-15 12:47 UTC (permalink / raw)
To: Sudeep Dutt, Ashutosh Dixit, Greg Kroah-Hartman
Cc: Arnd Bergmann, Vasyl Gomonovych, linux-kernel
A cleanup left an unused label behind:
drivers/misc/mic/vop/vop_vringh.c: In function 'vop_ioctl':
drivers/misc/mic/vop/vop_vringh.c:1001:1: error: label 'done' defined but not used [-Werror=unused-label]
This cleans it up as well.
Fixes: 30b7a2c19e29 ("misc: mic: Use memdup_user() as a cleanup")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/misc/mic/vop/vop_vringh.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c
index b995cf741388..01d1f2ba7bb8 100644
--- a/drivers/misc/mic/vop/vop_vringh.c
+++ b/drivers/misc/mic/vop/vop_vringh.c
@@ -998,7 +998,6 @@ static long vop_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
goto __unlock_ret;
}
ret = vop_virtio_config_change(vdev, buf);
-done:
kfree(buf);
__unlock_ret:
mutex_unlock(&vdev->vdev_mutex);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: mic: remove unused label
2017-12-15 12:47 [PATCH] misc: mic: remove unused label Arnd Bergmann
@ 2017-12-19 9:53 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-12-19 9:53 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Sudeep Dutt, Ashutosh Dixit, Vasyl Gomonovych, linux-kernel
On Fri, Dec 15, 2017 at 01:47:27PM +0100, Arnd Bergmann wrote:
> A cleanup left an unused label behind:
>
> drivers/misc/mic/vop/vop_vringh.c: In function 'vop_ioctl':
> drivers/misc/mic/vop/vop_vringh.c:1001:1: error: label 'done' defined but not used [-Werror=unused-label]
>
> This cleans it up as well.
>
> Fixes: 30b7a2c19e29 ("misc: mic: Use memdup_user() as a cleanup")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/misc/mic/vop/vop_vringh.c | 1 -
> 1 file changed, 1 deletion(-)
Colin beat you to this by 2 days :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-19 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-15 12:47 [PATCH] misc: mic: remove unused label Arnd Bergmann
2017-12-19 9:53 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox