From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965035AbdLSN7z (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 08:59:55 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:37304 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S964891AbdLSN7y (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 08:59:54 -0500
Date: Tue, 19 Dec 2017 14:59:55 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aniruddha Shastri <aniruddha.shastri@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
        H Hartley Sweeten <hsweeten@visionengravers.com>,
        Matthew Giassa <matthew@giassa.net>,
        Christopher =?iso-8859-1?Q?M=E5rtensson?= <cribalik@gmail.com>,
        Karthik Nayak <karthik.188@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: comedi: ni_*: Fix style warnings.
Message-ID: <20171219135955.GA32322@kroah.com>
References: <1513234104.27409.49.camel@perches.com>
 <1513236675-62337-1-git-send-email-aniruddha.shastri@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1513236675-62337-1-git-send-email-aniruddha.shastri@gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 14, 2017 at 01:31:05AM -0600, Aniruddha Shastri wrote:
> Two of these warnings are now line-too-long warnings. I think these 
> warnings are preferable to the ones listed below. The longest line is
> only 85 chars wide, which is reasonable.
> 
> Warnings fixed:
> ni_atmio.c:239: WARNING: Avoid multiple line dereference
> 	- prefer 'ni_boards[i].isapnp_id'
> ni_labpc_common.c:573: WARNING: Avoid multiple line dereference
> 	- prefer 'cmd->scan_begin_arg'
> ni_mio_common.c:736: WARNING: Avoid multiple line dereference
> 	- prefer 'devpriv->counter_dev->counters[gpct_index]'
> ni_mio_common.c:1977: WARNING: Prefer using '"%s...", __func__'
> 	to using 'ni_cmd_set_mite_transfer', this function's name, in a string
> ni_mio_common.c:1990: WARNING: Prefer using '"%s...", __func__'
> 	to using 'ni_cmd_set_mite_transfer', this function's name, in a string
> ni_mio_common.c:4302: WARNING: function definition argument
> 	'int' should also have an identifier name
> ni_mio_common.c:4302: WARNING: function definition argument
> 	'int' should also have an identifier name
> ni_mio_common.c:4302: WARNING: function definition argument
> 	'int *' should also have an identifier name
> ni_mio_common.c:4699: WARNING: Prefer using '"%s...", __func__'
> 	to using 'cs5529_do_conversion', this function's name, in a string
> ni_stc.h:21: WARNING: Block comments should align the * on each line
> 
> Signed-off-by: Aniruddha Shastri <aniruddha.shastri@gmail.com>
> ---
> Changes in v3:
> No longer add 'const' to sizeof(struct comedi_lrange) in ni_670x.c:212

Please only fix one "type" of issue per patch.  This should be broken up
into multiple patches and sent as a patch series.

thanks,

greg k-h