Re: thinkpad x60: sound problems in 4.15-rc1 was Re: thinkpad x60: sound problems in 4.14.0-next-20171114

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 5251 bytes --]

Hi!

> > > > > > > > > > Reappeared, 4.15-rc1.
> > > > > > > > > > 
> > > > > > > > > > [   40.473822] PM: suspend exit
> > > > > > > > > > [   40.526027] sdhci-pci 0000:15:00.2: Will use DMA mode even though
> > > > > > > > > > HW doesn't fully claim to support it.
> > > > > > > > > > [   40.569765] e1000e: eth1 NIC Link is Down
> > > > > > > > > > [   40.578257] sdhci-pci 0000:15:00.2: Will use DMA mode even though
> > > > > > > > > > HW doesn't fully claim to support it.
> > > > > > > > > > [   40.648476] sdhci-pci 0000:15:00.2: Will use DMA mode even though
> > > > > > > > > > HW doesn't fully claim to support it.
> > > > > > > > > > [   40.737339] sdhci-pci 0000:15:00.2: Will use DMA mode even though
> > > > > > > > > > HW doesn't fully claim to support it.
> > > > > > > > > > [   43.018955] wlan0: authenticate with 00:00:00:00:00:01
> > > > > > > > > > [   43.019072] wlan0: send auth to 00:00:00:00:00:01 (try 1/3)
> > > > > > > > > > [   43.023955] wlan0: authenticated
> > > > > > > > > > [   43.031721] wlan0: associate with 00:00:00:00:00:01 (try 1/3)
> > > > > > > > > > [   43.039733] wlan0: RX AssocResp from 00:00:00:00:00:01 (capab=0x401
> > > > > > > > > > status=0 aid=1)
> > > > > > > > > > [   43.042712] wlan0: associated
> > > > > > > > > > [  480.662456] snd_hda_intel 0000:00:1b.0: IRQ timing workaround is
> > > > > > > > > > activated for card #0. Suggest a bigger bdl_pos_adj.
> > > > > > > > > 
> > > > > > > > > This message is often superfluous, so don't take this too seriously.
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > > pavel@amd:~$
> > > > > > > > > > 
> > > > > > > > > > Again, mplayer has problems, mpg123 works. This time mplayer started
> > > > > > > > > > playing video (w/o sound) after long delay.
> > > > > > > > > > 
> > > > > > > > > > Uh. huh. And now problems appeared in mpg123, too, and then went away
> > > > > > > > > > in mpg123 _and_ mplayer. Interesting.
> > > > > > > > > > 
> > > > > > > > > > I suspect some pulseaudio fun. chromium always has sound problems,
> > > > > > > > > > then I restart chromium and everything is ok. But something changed in
> > > > > > > > > > -next and 4.15-rc1, because mplayer did not have problems before.
> > > > > > > > > 
> > > > > > > > > Hm, there is no code change at all in sound/*.  If it happens only in
> > > > > > > > > linux-next, it must be something else...
> > > > > > > > 
> > > > > > > > It happened first in -next, now it is in 4.15-rc1.
> > > > > > > 
> > > > > > > So you meant a possible regression between 4.14 and 4.15-rc1?
> > > > > > 
> > > > > > Yes.
> > > > > 
> > > > > Hm, as far as I see, the only significant difference is the commit
> > > > > 20e3f985bb875fea4f86b04eba4b6cc29bfd6b71
> > > > >     ALSA: pcm: update tstamp only if audio_tstamp changed
> > > > >     
> > > > > Another change d6c0615f510bc1ee26cfb2b9a3343ac99b9c46fb
> > > > >     ALSA: hda - Fix yet remaining issue with vmaster 0dB
> > > > >     initialization
> > > > > is basically for fixing a previous wrong fix, and it should influence
> > > > > on all use cases, not only for a specific application.
> > > > 
> > > > Happened again, this time on -rc3. It is more than "audio is silent"
> > > > -- apps behave strangely. Let me test with
> > > > 20e3f985bb875fea4f86b04eba4b6cc29bfd6b71 reverted.
> > > > 
> > > > Hmm. This is 4th regression this release cycle :-(.
> > > 
> > > 
> > > Today I jumped to 4.15-rc4 from 4.14-rc6, and have noticed some oddities
> > > with audio in youtube under firefox which I never experienced before.
> > > 
> > > If I pause the playback, the audio seems to infinitely loop on whatever
> > > is in the dma buffer.  Resuming playback works but now the expected
> > > audio has repeated pops and clicks mixed in with it.
> > > 
> > > Even closing firefox doesn't seem to stop the looping buffer...
> > > 
> > > Machine is an x61s 1.8ghz thinkpad, x86_64, debian stretch, .config attached.
> > > 
> > > This for me is a 4.15 blocker, and I presume it's related to Pavel's
> > > experience as the x60 isn't much different AFAIK.
> > > 
> > 
> > Just reproduced this, it seems to be trivial to repro and doesn't
> > actually require pausing or anything.  Simply watching a youtube video
> > causes the audio to get messed up after a short period.
> > 
> > I monitored `journalctl --dmesg --follow` while reproducing this and saw
> > this line appear at the very moment the audio got messed up:
> > 
> >   kernel: Monitor-Mwait will be used to enter C-3 state
> > 
> > Prior to that, everything seemed to be owrking fine.
> > 
> 
> After a lengthy bisect, I ended up with this being the bad commit:

You forgot to mention commit id :-).

> > Regards,
> > Vito Caputo
> 
> 
> Have not tested a revert yet, but it's reliably reproducible.
> 
> I mess up the audio by pulling the AC power while listening to music, causing
> things to run from battery.
> 
> Addressed to tglx since it's his commit...

Thanks for all the debugging!

									Pavel       

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]