Re: [RFC PATCH v2 00/13] Kernel based bootsplash

Neil Armstrong
2017-12-20T10:06:45Z

On 20/12/2017 10:43, Daniel Vetter wrote:
> On Tue, Dec 19, 2017 at 07:40:12PM +0100, Max Staudt wrote:
>> On 12/19/2017 06:26 PM, Daniel Vetter wrote:
>>> On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt <mstaudt@suse.de> wrote:
>>>> Well, those could enable fbcon if they want the bootsplash. Shouldn't make a difference anyway if they're powerful enough to run Linux. As long as the bootsplash is shown, no fbcon drawing operations are executed, so there is no expensive scrolling or such to hog the system.
>>>
>>> It's too big, and those folks tend to be super picky about space.
>>
>> I know, they really are.
>>
>> However, given just how big and clunky modern systems have become, I
>> raise my doubts about a few extra KB for fbcon code to be relevant.
>>
>> My feeling is that the kernel splash probably saves even more space on
>> the userspace side than it adds on the kernel side, thus netting a
>> reduction in overall code size.
>>
>>
>>> So essentially you're telling me that on a current general purpose
>>> distro the gfx driver loading is a dumpster fire, and we're fixing
>>> this by ignoring it an adding a hole new layer on top. That doesn't
>>> sound like any kind of good idea to me.
>>
>> Yes. It is a vast improvement over the status quo, and people are asking
>> for it. And the bootsplash layer can be moved elsewhere, just change the
>> hooks and keep the loading/rendering.
>>
>> Also, gfx driver loading isn't a dumpster fire, it mostly just works. It
>> just mustn't be done 100% carelessly.
>
> You've talked about using sleep and stuff to paper over races. That
> doesn't sound good at all.
>
>>> So if just using drm for everything isn't possible (since drm drivers
>>> can at least in theory be hotunplugged), can we at least fix the
>>> existing fbdev kernel bugs? Not being able to unplug a drm driver when
>>> it's still open sounds like a rather serious issues that probably
>>> should be fixed anyway ... so we're better able to hotunplug an fbdev
>>> driver when it's in use.
>>
>> I don't see it as a bug. The fbdev driver gets unloaded as much as
>> possible, but as long as a userspace application keeps the address_space
>> mmap()ed, there's nothing we can do, short of forcibly removing it and
>> segfaulting the process the next time it tries to render something. Am I
>> missing something?
>
> I guess you could remap that too ... But yeah SIGBUS ftw. Wrap rendering
> in a sighandler and abort if you hit that. In drm we try to be a bit
> better and keep things around until userspace has gone.
>
>>> Also I'm not clear at all on the "papering over races with sleeps"
>>> part. DRM drivers shouldn't be racy when getting loaded ...
>>
>> The DRM driver loading isn't racy, but the fbdev can't be fully unloaded
>> while Plymouth has the address_space mmap()ed. If Plymouth sleeps until
>> drivers that are included in initramfs are (hopefully) loaded, then it
>> will forego using its FB backend.
>>
>> A solution we've experimented with is dropping the FB backend from
>> Plymouth. It instantly fixed the busy video RAM bug. However it made the
>> folks relying on efifb very, very unhappy.
>>
>>
>>> Or we get simpledrm merged (for efifb and vesafb support) and someone
>>> types the xendrm driver (there is floating around, it's just old) and
>>> we could forget about any real fbdev drivers except the drm based
>>> ones.
>>
>> And drmcon, unless we come up with a better idea than hooking into the *con driver.
>
> If we have everything as drm drivers, you can just use plymouth (with no
> fbdev backend ofc) and everyone is happy. Including the efifb folks (it's
> simply going to be called efidrmfb or something like that). So no idea why
> you need a *con.
>
>> Sure, that'd help a lot. But what do we do until then?
>
> Make it happen? Twiddling thumbs is an option too ofc, but it tends to not
> result in results :-)
>
> Cheers, Daniel
>

My 2cents about this patchset:
You did a good job about all the animation and splash logic, but for me all this fbcon
stuff is a huge hack, please use a standard and modern display subsystem en leave fbcon
die alone....

My DRM ARM systems would love to have such bootsplash, so please, make it happen using DRM
then leave the fbcon based stuff like efifb migrate to DRM in a second time !

Neil