Re: [RFC PATCH v2 00/13] Kernel based bootsplash

Daniel Vetter
2017-12-21T09:48:11Z

On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote:
> Dear fbdev and fbcon developers,
>
> Thank you very much for your input for the first patch series.
>
> I've included your feedback into this second roll, and kindly ask for
> your opinion on the new patch series.
>
>
> Changes from v1 to v2:
>
> + Added a user space tool to create splash theme files
> + Bumped the file format version:
> - Larger structs for easy future expansion
> - 2-byte corner offset
> - Offset either from corner or from center
> - Fixed padding before header->frame_ms
> + Moved bootsplash_file.h to uapi/linux
> + Merged several patches
> + Theme files are now loaded via request_firmware()
> + sysfs hook to allow loading of theme files via request_firmware()
> + Dropped the .enable cmdline option and the default file name.
> The splash will be shown as soon as a file is specified.
> + Dropped custom workqueue in favor of the kernel queue
> and cancel_delayed_work_sync()
> + Marked loaded data as const, and load/enable it atomically
> + Reduced global state by moving data into other structures
> + EXPORT_SYMBOL_GPL for fbcon_set_dummyops()
> + Atomic and barrier for splash enabled state instead of spinlock
> + Reduced warnings to infos
> + Rate limited printk
> + Changed the multi-line comment layout to kernel style
> + Simplified the file headers
> + reST-ed the documentation

Ok, here's my expectation:

- fix plymouth and driver loading

If the plymouth maintainer tells me that's impossible, I'll look at this
again. And no, this does not require killing drivers with SIGBUS, at least
not with drm. Meanwhile I don't think this RFC makes sense to be merged.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation