From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755404AbdLTPZb (ORCPT ); Wed, 20 Dec 2017 10:25:31 -0500 Received: from mga14.intel.com ([192.55.52.115]:36795 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754664AbdLTPZ3 (ORCPT ); Wed, 20 Dec 2017 10:25:29 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,432,1508828400"; d="scan'208";a="19862995" Date: Wed, 20 Dec 2017 23:24:56 +0800 From: kbuild test robot To: Adam Thomson Cc: kbuild-all@01.org, Heikki Krogerus , Guenter Roeck , Greg Kroah-Hartman , Sebastian Reichel , Hans de Goede , Yueyao Zhu , Rui Miguel Silva , linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, support.opensource@diasemi.com Subject: [PATCH] typec: tcpm: fix ptr_ret.cocci warnings Message-ID: <20171220152456.GA73368@lkp-g5> References: <4a578dd161acf70aa33cc887493d2854547c0a2b.1513599506.git.Adam.Thomson.Opensource@diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a578dd161acf70aa33cc887493d2854547c0a2b.1513599506.git.Adam.Thomson.Opensource@diasemi.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fengguang Wu drivers/usb/typec/tcpm.c:4396:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 91886adfce05 ("typec: tcpm: Represent source supply through power_supply class") CC: Adam Thomson Signed-off-by: Fengguang Wu --- tcpm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/usb/typec/tcpm.c +++ b/drivers/usb/typec/tcpm.c @@ -4393,10 +4393,7 @@ int devm_tcpm_psy_register(struct tcpm_p port->psy = devm_power_supply_register(port->dev, &port->psy_desc, &psy_cfg); - if (IS_ERR(port->psy)) - return PTR_ERR(port->psy); - - return 0; + return PTR_ERR_OR_ZERO(port->psy); } struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)