From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Airlie <airlied@linux.ie>,
Jonathan Hunter <jonathanh@nvidia.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/tegra: fix non-debugfs builds
Date: Wed, 20 Dec 2017 19:59:52 +0100 [thread overview]
Message-ID: <20171220185952.GC9687@ulmo> (raw)
In-Reply-To: <20171218134519.3042726-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Mon, Dec 18, 2017 at 02:44:46PM +0100, Arnd Bergmann wrote:
> The new debugfs registration fails to build when CONFIG_DEBUGFS is
> disabled, because the drm_crtc structure is lacking a member in that
> configuration:
>
> drivers/gpu/drm/tegra/dc.c: In function 'tegra_dc_late_register':
> drivers/gpu/drm/tegra/dc.c:1204:28: error: 'struct drm_crtc' has no member named 'debugfs_entry'
>
> Without CONFIG_DEBUGFS, the rest of the function already degrades
> into nothing, so we just avoid the one assignment.
>
> Fixes: b95800eeef09 ("drm/tegra: dc: Register debugfs in ->late_register()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/tegra/dc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
I don't think I replied, but I had applied this yesterday, so this
should be fixed in linux-next today.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-12-20 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 13:44 [PATCH] drm/tegra: fix non-debugfs builds Arnd Bergmann
2017-12-20 18:59 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220185952.GC9687@ulmo \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).