From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752859AbdLUJVQ (ORCPT ); Thu, 21 Dec 2017 04:21:16 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:41700 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbdLUJVO (ORCPT ); Thu, 21 Dec 2017 04:21:14 -0500 Date: Thu, 21 Dec 2017 10:21:12 +0100 From: Andrew Lunn To: Grygorii Strashko Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sekhar Nori Subject: Re: [PATCH] net: phy: micrel: ksz9031: reconfigure autoneg after phy autoneg workaround Message-ID: <20171221092112.GD6683@lunn.ch> References: <20171221004510.29715-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171221004510.29715-1-grygorii.strashko@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 20, 2017 at 06:45:10PM -0600, Grygorii Strashko wrote: > Under some circumstances driver will perform PHY reset in > ksz9031_read_status() to fix autoneg failure case (idle error count = > 0xFF). When this happens ksz9031 will not detect link status change any > more when connecting to Netgear 1G switch (link can be recovered sometimes by > restarting netdevice "ifconfig down up"). Reproduced with TI am572x board > equipped with ksz9031 PHY while connecting to Netgear 1G switch. > > Fix the issue by reconfiguring autonegotiation after PHY reset in > ksz9031_read_status(). Hi Grygorii I can understand the fix. But i'm wondering if there is a better way to do this. Can you call phy_stop() and phy_start(). You then get the core phy code doing the same initialisation as what happened the first time. However, i know this is not easy. _read_status() is being called from the middle of the state machine, and trying to change the state of the state machine at this point is problematic. Andrew